Add encode-microphone example #291
Conversation
|
CI failure seems unrelated to this change (?) |
| @@ -31,6 +31,11 @@ serde_json = "1.0" | |||
| bytes = "1.1" | |||
| lazy_static = "1.4" | |||
| rand = "0.8" | |||
| # encode-microphone | |||
| cpal = "0.14.0" | |||
There was a problem hiding this comment.
I would drop the patch and stick to major and minor like most of the other lines
|
|
||
| #[tokio::main] | ||
| async fn main() -> Result<()> { | ||
| let mut app = Command::new("encode-microphone") |
There was a problem hiding this comment.
check out clap derive, it's pretty nice.
| // Create a MediaEngine object to configure the supported codec | ||
| let mut m = MediaEngine::default(); | ||
|
|
||
| m.register_default_codecs()?; |
There was a problem hiding this comment.
since this is very opus specific maybe only register Opus
| Result::<()>::Ok(()) | ||
| }); | ||
|
|
||
| let (sender, frame_receiver) = flume::bounded::<AudioFrame>(3); |
There was a problem hiding this comment.
do you need to add extra dependency on flume here or can you just use tokio channels?
| let (encoded_sender, encoded_receiver) = flume::bounded::<AudioEncodedFrame>(3); | ||
|
|
||
| // Encoder thread | ||
| thread::spawn(move || { |
There was a problem hiding this comment.
maybe add some commandline option here with default 48000kHz but it can be overriden in case there is stereo mic with 16kHz sampling rate for example?
| let (encoded_sender, encoded_receiver) = flume::bounded::<AudioEncodedFrame>(3); | ||
|
|
||
| // Encoder thread | ||
| thread::spawn(move || { |
There was a problem hiding this comment.
do you need a separate thread for encoder only? can't this run on the same thread as rtp send?
There was a problem hiding this comment.
I’d like that too, but since Encoder didn’t impl Send I guess it wasn’t possible to use it across awaits in an async thread. Is there a solution?
There was a problem hiding this comment.
not sure, (I am not a very good rust async programmer :) )
| eprintln!("an error occurred on stream: {}", err); | ||
| }; | ||
|
|
||
| // until it is 960 |
There was a problem hiding this comment.
make a comment what 960 is, my guess it's 20ms frame with 48kHz sampled data.
There was a problem hiding this comment.
Correct, I should replace it with a const and a comment.
| }; | ||
|
|
||
| // until it is 960 | ||
| let mut buffer: Vec<f32> = Vec::new(); |
There was a problem hiding this comment.
with_capacity to preallocate all memory
| #[cfg(any( | ||
| not(any(target_os = "linux", target_os = "dragonfly", target_os = "freebsd")), | ||
| not(feature = "jack") | ||
| ))] |
| let host = cpal::default_host(); | ||
|
|
||
| // Set up the input device and stream with the default input config. | ||
| let device = if device == "default" { |
There was a problem hiding this comment.
since you already hardcode device on 316 the else is not relevant here.
|
@morajabi I'm holding of on reviewing this until CI passes FYI |
No description provided.