-
-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: webpack template generator for webpack repos #4152
Conversation
To add a boilerplate
reverted to orignal state
undone uneccesssary changes
args[templateIndex + 1] == "webpack" | ||
) { | ||
this.template = args[templateIndex + 1]; | ||
// now if the template is webpack, then we follow the execution of webpack-defaults ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to move all logic of webpack-defaults here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i.e. the same files, configuration and etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it, working on it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have a gsoc project working on CWA (Create Webpack App) and we will not accept his pr at this time. Thank you for the contribution though! Maybe we can find another issue for you to solve?
With reference to #3768
The following --template flag will be introduced
And the template webpack will act as a replacer for webpack-defaults
I have only added the basic idea of execution, please lemme know if it is interprated correctly; then ill continue.