Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bundle analyzer #4141

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Conversation

info-arnav
Copy link

created a cli flags file, please review. if correct ill move forward to complete it.

@snitin315 @alexander-akait

#1838

@info-arnav info-arnav requested a review from a team as a code owner April 6, 2024 22:50
cli-flags.js Outdated
@@ -0,0 +1,159 @@
"use strict";

module.exports = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed? What problem does it solve?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the file is made to privde the flags for the bundle analyzer plugin, had kept it in the root directory for now. Will move it to appropriate place.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let me know if somethings wrong, or how to proceed further.

package.json Outdated Show resolved Hide resolved
packages/webpack-cli/src/webpack-cli.ts Outdated Show resolved Hide resolved
packages/webpack-cli/src/webpack-cli.ts Outdated Show resolved Hide resolved
simpleType: "boolean",
multiple: false,
},
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please send it to https://github.com/webpack-contrib/webpack-bundle-analyzer, this PR should be done in webpack-bundle-analyzer repo and here we just will read it from require("webpack-bundle-analyzer").cli.arguments

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@info-arnav could you do that?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants