This repository has been archived by the owner on Oct 9, 2020. It is now read-only.
Fix: idPrefix regex to support style attribute #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
koox00
changed the title
mathroc
reviewed
Aug 14, 2019
lib/transformer.js
Outdated
| @@ -131,7 +131,7 @@ function createClassPrefix(classPrefix) { | |||
| } | |||
|
|
|||
| function createIdPrefix(idPrefix) { | |||
| var url_pattern = /^url\(#.+\)$/i; | |||
| var url_pattern = /url\(#.+?\)/i; | |||
There was a problem hiding this comment.
@mathroc to enable lazy mode.
In greedy mode, the following
<g style="mask: url(#foo); color: rgba(0, 0, 0, 0, .1)">
would match
url(#foo); color: rgba(0, 0, 0, 0, .1)
but we want
url(#foo)
Currently createIdPrefix for tag attributes only works if the url is the first value. e.g: <path mask="url(#foo")> This commit adds support also for the following. <g style="mask: url(#foo)">
anikethsaha
reviewed
Feb 8, 2020
| @@ -131,7 +131,7 @@ function createClassPrefix(classPrefix) { | |||
| } | |||
|
|
|||
| function createIdPrefix(idPrefix) { | |||
| var url_pattern = /^url\(#.+\)$/i; | |||
| var url_pattern = /url\(#.+?\)/gi; | |||
There was a problem hiding this comment.
it wont work for this
<path mask="url(#foo")>
I guess keeping both can be better
There was a problem hiding this comment.
@anikethsaha It passes the tests though.
why wouldn't it work?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently createIdPrefix for tag attributes only works if the
url(#foo)is the only value.e.g:
This commit adds support for the following.