Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix all current clippy warnings #80

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix all current clippy warnings #80

wants to merge 1 commit into from

Conversation

lpenz
Copy link

@lpenz lpenz commented Oct 2, 2022

  • Call function directly in .map
  • Use .is_empty
  • Remove redundant "return"
  • Remove unnecessary references
  • etc.

@lpenz
Fix all current clippy warnings
3fe24f2 
- Call function directly in .map
- Use .is_empty
- Remove redundant "return"
- Remove unnecessary references
- etc.
stmcginnis
stmcginnis approved these changes Jun 22, 2023
View reviewed changes
Copy link

@stmcginnis stmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There may be some newer clippy warnings since then since it seems to add a few more every release. But these are good and should be applicable for most current rust versions in use out there.

@lpenz
Copy link
Author

lpenz commented Jun 22, 2023

Sure, this pull request is now 8 months old
I can fix the new warnings, but looks like this project has been inactive for 2 years now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmcginnis stmcginnis stmcginnis approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lpenz @stmcginnis