-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Adding the WebWorker feature to WebARStudio #1
base: master
Are you sure you want to change the base?
Conversation
At the moment it can track the NFT marker, because i can see the messages in the console. The video is displayed but is not correclty closed/deleted when it is pushed the stop button. This need to be fixed. And model is not displayed probably need to be fixed some retrieved values (matrix or related stuff) |
Things to do:
|
I am back on this. 😄
Probably markerRoot is not correct? I should compare my version code with the previous one, I think something is wrong in my implementation... |
- need to fix this also in the master branch - must be verified
@ThorstenBux i will apply that fix also in the master branch. Anyway this should be tested, before to merge it. I think we are very close for a new release... |
If someone want to try, test WebARStudio at this link |
Tested again the code: with the latest, sometimes i receive the error already reported, not the same but it came from that: arcontroller.component.js?version=0.64:91 Uncaught TypeError: Cannot read property 'childNodes' of null
at arcontroller.component.js?version=0.64:91
at found (webWorker.js:189)
at Worker.worker.onmessage (webWorker.js:60) it appear when i stop the video and restart the simulation. |
This PR will add the WebWorker feature to the editor.
Features and code changed:
JsartoolkitNFT from master branch https://github.com/webarkit/jsartoolkitNFT