Include AWS Key param in callback post #189
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 17, 2014 15:18
Returning the key is important, when a filename contains Spaces or other non-url safe characters the ‘Location’ parameter has encoded them. When this happens, it’s impossible to use the ‘url’ as the key when referencing the file via the AWS SDK as a bucket object. e.g. I upload a file called ‘I have spaces.txt’. The ‘Location’ in AWS’s response is ‘https://[bucket].s3.amazonaws.com/I+have+spaces.txt' If we try to use this url to determine the key, URI.decode leaves the +’s in there. The +’s could have been part of the original filename ‘I+have+strings.txt’. There’s no good way to clean the filename before hand, so, this really needs to return the key back to the callback url along with the url/location.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returning the key is important, when a filename contains Spaces or
other non-url safe characters the ‘Location’ parameter has encoded
them. When this happens, it’s impossible to use the ‘url’ as the key
when referencing the file via the AWS SDK as a bucket object.
e.g. I upload a file called ‘I have spaces.txt’. The ‘Location’ in
AWS’s response is ‘https://[bucket].s3.amazonaws.com/I+have+spaces.txt'
If we try to use this url to determine the key, URI.decode leaves the
+’s in there. The +’s could have been part of the original filename
‘I+have+spaces.txt’.
There’s no good way to clean the filename before hand, so, this really
needs to return the key back to the callback url along with the
url/location.
It's important to provide the content unchanged so that it can be referenced via the API.