Replace filepath with key in callback request #165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe it is more useful to send the key instead of filepath to the callback_url. For example, I need the key to do additional processing on the server. Amazon also returns the key and probably for the same reason. I don't see any reason why not to return the data from Amazon (url and key) and return filepath instead.
Moreover, the current implementation has several issues in IE9:
/uploads/foo/bar.jpg
it was returning only/uploads/foo
/
. For filepaths such as/uploads/foo/bar.jpg
it was returning onlyuploads/foo