Merge mesa-24.2.5 #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is based on format features cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31467> (cherry picked from commit f3c206d61e24baa04467d5b8508230ac8da15431)
these are already a set format cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31467> (cherry picked from commit f7b5faa1a276a29b1de9a87a645320703bc3d841)
These extensions were experimental and only exposed with radv_dgc=true for vkd3d-proton. Only two games require DGC (Starfield and Halo Infinite) and both also require sparse support which GFX6-7 can't support. GFX6-7 support is also mostly broken because IB2 can't be used when indirect draw packets are used and RADV uses that to preprocess IBO. Also with the EXT, indirect draws are more common and can't be supported. Everything could work with a bunch of time and workarounds but I don't think it's worth the effort given there is no real use. Cc: mesa-stable Signed-off-by: Samuel Pitoiset <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31491> (cherry picked from commit e4f67f2106768eeb34ea40ac73a298e19fe5969f)
The shader uniforms used for emulating TXS depend on the current sampler view state and thus need to be re-emitted when this states changes. Fixes: 88f399b ("etnaviv: nir: support intrinsic used for txs lowering") Signed-off-by: Lucas Stach <[email protected]> Reviewed-by: Christian Gmeiner <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31495> (cherry picked from commit c12697abe0cb6aac45aeac3ebb9e55f64cfc9f37)
What we really want to pass is DRM_IOCTL_I915_GEM_CONTEXT_GETPARAM vs DRM_IOCTL_I915_GEM_CONTEXT_SETPARAM Fixes: a9f1151 ("intel/hang_replay: use hw image param") Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/11959 Signed-off-by: Carlos Santa <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31494> (cherry picked from commit 700141da43d9ec13d5deffedb14c3c4a9266f8d9)
This flag causes the following failure: total_vma: 0x0000000071c9d000 fail to set context hw img: Invalid argument Fixes: bab5276 ("intel/hang_replay: fix batch address") Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/11959 Signed-off-by: Carlos Santa <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31494> (cherry picked from commit 39e3015c3609408d7f0c698fc750b2f040049446)
This reverts commit b36d9d9a31f475e375db228c74fb4e317edd72fa. This commit is causing issues [1] and is not worth backporting, so let's just revert it. [1]: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31485#note_2599128
Cc: mesa-stable Signed-off-by: Tapani Pälli <[email protected]> Reviewed-by: Nanley Chery <[email protected]> Reviewed-by: Lionel Landwerlin <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29764> (cherry picked from commit 8cb08830e6bfee6940ed1a3933f7fa626792b293)
Cc: mesa-stable Signed-off-by: Tapani Pälli <[email protected]> Reviewed-by: Nanley Chery <[email protected]> Reviewed-by: Lionel Landwerlin <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29764> (cherry picked from commit 03f762f90c54c09e58cc736e0ac7c684ac367a45)
Cc: mesa-stable Signed-off-by: Tapani Pälli <[email protected]> Reviewed-by: Nanley Chery <[email protected]> Reviewed-by: Lionel Landwerlin <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29764> (cherry picked from commit e3814dee1ac0f90771b921a4f6f5aed10f06e8d4)
Cc: mesa-stable Signed-off-by: Tapani Pälli <[email protected]> Reviewed-by: Nanley Chery <[email protected]> Reviewed-by: Lionel Landwerlin <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29764> (cherry picked from commit 11774075a354dda934aaedcfb34bd88956806d41)
These should be included according to table in Bspec 43904. Patch removes PIPE_CONTROL_STATE_CACHE_INVALIDATE based on HSDES. Cc: mesa-stable Signed-off-by: Tapani Pälli <[email protected]> Reviewed-by: Nanley Chery <[email protected]> Reviewed-by: Lionel Landwerlin <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29764> (cherry picked from commit 3e29ea69ce683b23dd8708f13dd8b98433a3c59c)
These should be included according to table in Bspec 43904. Patch removes PIPE_CONTROL_STATE_CACHE_INVALIDATE based on HSDES. Cc: mesa-stable Signed-off-by: Tapani Pälli <[email protected]> Reviewed-by: Nanley Chery <[email protected]> Reviewed-by: Lionel Landwerlin <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29764> (cherry picked from commit 78b614b333b01ce0dfb9e4d9353a02a03fdcc154)
Preprocess now must use the same conditional rendering state as the execute, so the DGC prepare shader must reset the number of sequences to generate an empty cmdbuf for compute. Cc: mesa-stable Signed-off-by: Samuel Pitoiset <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31563> (cherry picked from commit 336f80137d26230bd124f475bd4382a0c727004f)
Check if the block size is bigger then 64. We want to block e.g. one of the following formats: - R32G32B32A32_FLOAT - R32G32B32A32_SINT - R32G32B32A32_ZINT Unbreaks e.g. dEQP-GLES3.functional.fbo.completeness.renderable.texture.color0.rgb16i Fixes: e481c12 ("etnaviv: disable 64bpp render/sampler formats") Signed-off-by: Christian Gmeiner <[email protected]> Reviewed-by: Lucas Stach <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27111> (cherry picked from commit 04521c14b0d90f54228809d240630e35033f39a4)
Starting with Linux v6.11+, performance counter information is no longer duplicated in both the kernel and userspace. Instead, an IOCTL retrieves this information, allowing userspace to maintain a local array for reuse, thus avoiding redundant kernel queries. However, support for older kernels without these new IOCTLs remains. To distinguish between versions, we check `devinfo->max_perfcnt` - which is non-zero on Linux v6.11+ and zero on older kernels. Currently, applications using performance queries on platforms with older kernels encounter a SEGFAULT, as we don't validate `devinfo->max_perfcnt` before accessing the userspace array for performance counter information. This commit makes sure that, if `devinfo->max_perfcnt` is zero, `screen->perfcnt_names` will be NULL. This way, we can check if `screen->perfcnt_names` is different than NULL before attempting to use the userspace array. Fixes: 017dde0 ("v3d: Use DRM_IOCTL_V3D_GET_COUNTER to get perfcnt information") Signed-off-by: Maíra Canal <[email protected]> Reviewed-by: Juan A. Suarez <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31552> (cherry picked from commit 47a78614eaece530244a23ec630e57b24654db46)
Signed-off-by: Lionel Landwerlin <[email protected]> Cc: mesa-stable Reviewed-by: Nanley Chery <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31579> (cherry picked from commit 52263413f47e9190d9f53c9ef336c3ab46070598)
Cc: mesa-stable Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/11992 Signed-off-by: Tapani Pälli <[email protected]> Reviewed-by: Lionel Landwerlin <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31573> (cherry picked from commit f77ffd6b7c870a3355b8920fe2aa4da0e2721b4b)
Fixes coverity issue 1559460 Out-of-bounds write Fixes: 9c07a2e ("radeonsi/vcn: ROI feature implementation") Reviewed-by: Leo Liu <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31558> (cherry picked from commit 10a73564889a81329bf5b79744a8bc3a8c4bdeed)
When all 16 references are used, this would read pic->ref[16]. Same for HEVC, but HEVC only uses 15 reference frames so it would never happen there yet is still reported by coverity. Fixes coverity issues 1497283 and 1465569 Out-of-bounds read Cc: mesa-stable Reviewed-by: Leo Liu <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31558> (cherry picked from commit 20d5020ad718743af593f80755117153d0288a4a)
Fixes: 9e90d95 ("v3d,v3dv: support up to 8 render targets in v7.1+") Reviewed-by: Iago Toral Quiroga <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31582> (cherry picked from commit 687ed3fcaa831376a9a3a9860400959eb4633569)
Fixes #11896. cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31533> (cherry picked from commit fa9cd89a85b904615ebc11da609445b5b751e68d)
Spec allows calling VkBufferGetDeviceAddressInfo without binding to memory: VUID-VkBufferDeviceAddressInfo-buffer-02600 If buffer is non-sparse and was not created with the VK_BUFFER_CREATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT flag, then it must be bound completely and contiguously to a single VkDeviceMemory object Which we can only do by making it sparse unconditionally, which feels very wrong to me for a capture & replay extension as that significantly impacts execution. Current theory is that this was only intended for the EXT and not the core functionality. As such, let's disable capture using the EXT. Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31140> (cherry picked from commit c8c354d9c3a2e79230723f1c8b0571b20d034fee)
There is no HW support, but in some cases the shaders mostly work even if we ignore it, and so far we have just done so. However since the driver didn't know to what output position in the PVS we should redirect it, it ended in the first slot. Importantly, if the CLIP_VERTEX output would be written after position (which actually belongs in the first slot) it would overwrite it and things blow up. So just remove it early, and also improve the warning a bit, including the part that we could use draw module to actually emulate the feature. Signed-off-by: Pavel Ondračka <[email protected]> Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/11856 Fixes: 5dcef1e Reviewed-by: Filip Gawin <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31547> (cherry picked from commit cc14d402393a5fbedeec6ac7d4f936e6b9050d7e)
Fixes: 5de33f3 ("freedreno: Implement stencil blit fallback") Signed-off-by: Rob Clark <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31569> (cherry picked from commit c7b126f6273eb4e60f3d36822593e90ad529251a)
The Vulkan spec says:
"If the buffer was created with a non-zero value of
VkBufferOpaqueCaptureAddressCreateInfo::opaqueCaptureAddress or
VkBufferDeviceAddressCreateInfoEXT::deviceAddress, the return
value will be the same address that was returned at capture time."
My interpretation is that you can get the buffer device address before
binding if you passed a non-zero address during buffer creation. The
returned BDA would be similar if a memory object is bound to the
buffer later.
Cc: mesa-stable
Signed-off-by: Samuel Pitoiset <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31145>
(cherry picked from commit 03b4477c8feb4b0b235c9558b73495bb4c815fa8)
The declaration and definition used by tests otherwise differs from addrlib. Found by LTO -Werror=lto-type-mismatch. Fixes: 1d69c04 ("amd/addrlib: prevent defining regparm differently") Reviewed-by: Marek Olšák <[email protected]> Signed-off-by: David Heidelberg <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31613> (cherry picked from commit d14d3c5bdda9947c9bfb16d30c0e95798362af02)
…rounds Otherwise, they aren't applied if shaders are pre-compiled using builders because the executable name would be fossilize-replay. Using pApplicationName is the correct way to do because it's replayed by Fossilize correctly. Cc: mesa-stable Signed-off-by: Samuel Pitoiset <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31621> (cherry picked from commit 56813236f47a8d2f8d7fe3dfb3909797176f6e82)
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/11987 Signed-off-by: Tapani Pälli <[email protected]> Acked-by: Lionel Landwerlin <[email protected]> Reviewed-by: David Heidelberg <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31540> (cherry picked from commit a3c03b6a96ff3c914ca8dcc675005cf986203d03)
Backport-to: 24.2 Ref: https://gitlab.freedesktop.org/drm/kernel/-/commit/35667a0330612bb25a689e4d3a687d47cede1d7a Ref: bspec 55420 Signed-off-by: Jordan Justen <[email protected]> Reviewed-by: Lionel Landwerlin <[email protected]> Reviewed-by: Rohan Garg <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31618> (cherry picked from commit 0530d4d59d7727fcefab1bff870b9923ea9f2098)
Correct copy-paste typo of depth_cpp instead of depth and use nullptr instead of NULL, as GTest suggest in documentation: When comparing a pointer to NULL, use EXPECT_EQ(ptr, nullptr) instead of EXPECT_EQ(ptr, NULL). Fixes: ef9362a ("gallium/osmesa: Return cleanly for OSMesaGetDepthBuffer() with no depth.") Signed-off-by: David Heidelberg <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31606> (cherry picked from commit 321012b95d61cf1c081079376ffab7f159a6368b)
Fixes: 2de9577 ("panvk: Kill panvk_private.h") Reviewed-by: Roman Stratiienko <[email protected]> Reviewed-by: Mary Guillemard <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31610> (cherry picked from commit 2c79e012593178075eac31dfa907ea64bf448b1c)
Fixes: d681cf96fbf9 ("nir/glsl: set deref cast mode during function inlining")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/11980
Reviewed-by: Marek Olšák <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31554>
(cherry picked from commit 46facf903778dfb2ae530cbb2cf4d1f660d467dd)
…ores uncovered by unrelated work Fixes: 2514999 - nir: add nir_opt_vectorize_io, vectorizing lowered IO Reviewed-by: Konstantin Seurer <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31644> (cherry picked from commit 64c4d29e65853d0c31a5c2adcd749077b39bc446)
We also add an nvk_format_supports_atomics() helper. This helper lives in NVK for now because it's not just about the format and hardware but also about whether or not we have compiler support in NAK. Fixes: 1d10de5 ("nvk: Implement VK_EXT_shader_image_atomic_int64") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31633> (cherry picked from commit c2684968de46a1c1a0ab80a9104c48b742c687c2)
…ce == NULL Fixes: 3df9d8e - gallium/u_threaded: implement pipelined partial buffer uploads using CPU storage Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/12020 Reviewed-by: Mike Blumenkrantz <[email protected]> Reviewed-by: Pierre-Eric Pelloux-Prayer <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31651> (cherry picked from commit 88f057eb531180c37f0d2c2d5bbbdc6e0a261816)
This was missing. Cc: mesa-stable Reviewed-by: Pierre-Eric Pelloux-Prayer <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31651> (cherry picked from commit 2272db2ac66561e4389d4101596480234378e00d)
More cast fixes this time for UBO and SSBO. Which were missing testing
previously.
Fixes: d681cf96fbf9 ("nir/glsl: set deref cast mode during function inlining")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/11587
Reviewed-by: Marek Olšák <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31668>
(cherry picked from commit aa7c59e02cfffa70cac83b2c126fbb5bd313ff6c)
Texel buffer could be arbitrary large, so the assumption being made in the following comment is wrong: "Zero-extension (u16) and sign-extension (i16) have the same behavior here - txf returns 0 if bit 15 is set because it's out of bounds and the higher bits don't matter." Sign extension should matter for GLSL_SAMPLER_DIM_BUF. This fixes the case of doing texelFetch with u16 offset: uniform itextureBuffer s1; uint16_t offset = some_ssbo.offset; value = texelFetch(s1, offset).x; If the offset is higher than s16 optimization incorrectly left it as 16b. In spirv the above glsl is translated into: %22 = OpLoad %ushort %21 %23 = OpUConvert %uint %22 %24 = OpBitcast %int %23 %26 = OpImageFetch %v4int %16 %24 Cc: mesa-stable Signed-off-by: Danylo Piliaiev <[email protected]> Reviewed-by: Georg Lehmann <[email protected]> Reviewed-by: Connor Abbott <[email protected]> Reviewed-by: Rob Clark <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31664> (cherry picked from commit 7b09fc98fb60becde7435b2303f7dd329937f6cb)
Those are supported by elk, not brw. Backport-to: 24.2 Reviewed-by: Caio Oliveira <[email protected]> Reviewed-by: Ian Romanick <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31499> (cherry picked from commit a9d948878894660f97dd6d63618ced35400aec77)
Saves typing .exec_all() in a lot of places. Backport-to: 24.2 Reviewed-by: Caio Oliveira <[email protected]> Reviewed-by: Ian Romanick <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31499> (cherry picked from commit 7c9eb8b289bb6fe891cae78377e94589299afeb4)
We were manually allocating 1 REG_SIZE for the barrier payload, which is only half a register on Xe2. This should eventually get allocated to a whole register anyway, but it's awkward in the meantime. Also, we were zero-initializing the header using group(8, 0) which only initialized half the register. The rest of the fields are Reserved MBZ, so they're likely unused and unread anyway - but it's better to zero-initialize them so we don't get random undefined, miserable-to-debug behavior. Backport-to: 24.2 Reviewed-by: Caio Oliveira <[email protected]> Reviewed-by: Ian Romanick <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31499> (cherry picked from commit dea61b739913fe85981cd3ef3ec563087c15b8da)
These platforms are supported by elk, not brw. Backport-to: 24.2 Reviewed-by: Caio Oliveira <[email protected]> Reviewed-by: Ian Romanick <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31499> (cherry picked from commit d9e502265034848b7908afa9a974cc0d618e1197)
Xe2 increased the register size from 256-bits to 512-bits. So we can store 32 16-bit values in a register, rather than 16 values. Prior to this patch, we hadn't updated the pass, so the second half of each of our registers was unused. Backport-to: 24.2 Reviewed-by: Ian Romanick <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31499> (cherry picked from commit 4cb67cb07ae53dd47b261ce6a236899bf1cf7ea6)
When we create sparse resources the first thing we do is a NULL bind
on them, as the Vulkan spec mandates certain behavior even for unbound
sparse resources. We do this with the minimal effort possible: if we
can get away with marking an L2 pointer as NULL in the L3 table, we
just do it and return, instead of going all the way to creating L1
tables and marking all the final entries as NULL.
The strategy we were using had a bug that could lead to previously
created NULL entries not being marked as NULL anymore. Let's give an
example:
(before proceeding, keep in mind that a NULL entry in the L3 and L2
tables has bit 1 set, it does *not* have the value 0)
- Create a 64mb buffer that uses an entire L1 table (needs to be
properly aligned), which triggers a NULL bind.
- Our algorithm will just set the L3 entry (pointing to the L2
table) as NULL.
- Create a 64kb buffer that uses the same L2 table (but a different
L1 table).
- The NULL bind triggered won't do anything as the L2 table is
already NULL.
- Bind the first buffer to actual memory. This will end up creating
the L2 table and the L1 table. The only entry we will set in the L2
table will be the one pointing to the L1 table. All the other
values will be 0 (so they won't have neither the NULL or Invalid
bits set: access to them will lead to page faults).
- Try to use the second buffer, which is still unbound. It was
relying on the fact that its L2 table pointer was NULL, but now
it's not anymore, so the page walker will fetch the L1 entries in
the L2 table and they will all be zero instead of having the NULL
bit set.
The fix is pretty simple: whenever we create a new L2 table, set every
entry to NULL (except the one we're about to set to non-NULL). This
preserves behavior for every other NULL resource relying on the L3
entry being set to NULL.
We don't need to do this for the L1 table because its entries are
different and instead of having bits to signal NULL entries we have
a special TR-TT register that we can set that gets compared to check
if an entry is NULL, and we conveniently program it to 0: see
ANV_TRTT_L1_NULL_TILE_VAL.
I am not aware of any real workloads that are triggering this
behavior, I found this issue while investigating something else,
running a custom sparse program in our pre-silicon environment, and it
told us about the page faults.
Cc: mesa-stable
Reviewed-by: Lionel Landwerlin <[email protected]>
Signed-off-by: Paulo Zanoni <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30953>
(cherry picked from commit 4c366ef67bd9e45618bb16826fc2f60e2f949892)
We're missing a check for 'result' in the middle of a loop and we have an unnecessary check for 'result' after the loop. Fixes: 7da5b1c ("anv: move trtt submissions over to the anv_async_submit") Reviewed-by: Lionel Landwerlin <[email protected]> Signed-off-by: Paulo Zanoni <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30953> (cherry picked from commit aea9ac47d23d842bc1b10241c36fd8db7653113d)
mesa-24.2.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading to mesa-24.2.5 required during compiling LineageOS 20 image for Waydroid. I haven't tested it on LineageOS 18.1 yet. But, i think it would be help for someone else to build LineageOS 20/Android images.