-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(clipboard): implement clipboard integration #91
feat(clipboard): implement clipboard integration #91
Conversation
Add the --clipboard flag and implement functionality to make image available on the clipboard using wl-clipboard-rs.
Apart from some stylistics nits which can be addressed later on this pr looks fine to me! Thanks for the contribution. CC: @Decodetalkers Can I get your input on it too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems good to me!
I tried this out and found that it could be pretty easily done with the help of the fork crate: https://docs.rs/fork/latest/fork/ |
I think it's worth the dependency graph increase in this case. You can edit this pr itself. |
Add functionality offering image on clipboard persistently in the background
Have added info about the wayshot persisting in background to the cli flag's description. Is there anything else that needs to be done here? |
Oops, corrected the typo. |
Thank you for your work! |
Something I forgot to suggest but which can be done later - documentation ( the flag should've been explained for the users.) |
As in the man pages? It is already documented in the CLI help. The man pages are entirely out of sync with the CLI changes in this branch. They will all have to be modified. |
Yes
I am aware but incrementally fixing it while introducing the changes is ideal, I will rewrite the outdated docs anyways. |
This PR adds a --clipboard flag and implements functionality to make the screenshot available on the clipboard using wl-clipboard-rs. All the caveats described in #89 (comment) are still applicable: