-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add screencopy dmabuf backend #122
Add screencopy dmabuf backend #122
Conversation
It isn't clear to me why that build is failing. Seems to be some issue with the wayland deps? Reading the code, I discovered that there are three levels of abstraction in libwayshot:
First Draft API ImplementationFor the first phase I decided to create dmabuf version of the lower two levels of abstraction. My goal was to create a dmabuf equivalent for To this goal, I created the new function variants Two new structs For the most part adapting the code from the MVP into these functions was straightforward with the shm variants as a reference. One part I have some trouble with is error handling. Using unwrap() in library code is generally frowned upon but I haven't figured out a good way to pass up errors to the caller without running into compiler errors like "? couldn't convert the error to The next phase will be testing. I will need some way to test the new API, ideally without having any VRAM->CPU copying. The simplest plan is to start with a basic wayland window demo and attach the |
- Add error handling - Add example/demo for wayshot dmabuf API
- Improved API docs for dmabuf functions
…es into GL textures
Apart from these minor changes, everything else looks good! |
Ci is failing @CheerfulPianissimo |
The addition of wayland-sys as a dependency is causing it to fail I think. That library requires a preinstalled wayland system library. |
fixed that but it seems we need something for egl too. |
alright, the build is passing now but I think it may be wise to document the new deps somewhere and/or feature-gate it. |
We can have it as part of changelog or release notes. Sounds good? |
Yeah that's fine by me. I already have a draft changelog for this at https://cheerfulpianissimo.github.io/notes/GSOC/GSoC%20Changelog.html |
Congratulations and thank you for your service to the open source community @CheerfulPianissimo |
This PR will contain the changes required for my Google Summer of Code 2024 project with waycrate as described here: https://cheerfulpianissimo.github.io/notes/GSOC/GSOC.html