Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing conversion from_str to webp enum #121

Merged
merged 5 commits into from
Jun 18, 2024

Conversation

Gigas002
Copy link

Missed in the PR #98 I proposed with this feature, sorry.
Was implemented as part of #104, but since there was a request to separate stuff from it here's this PR

@Shinyzenith
Copy link
Member

Thank you so much @Gigas002. I have had a big backlog of reviews so my apologies for the same. If you're no longer interested in the config pr then I'd be willing to look into it ( I understand it's been a while )

@Shinyzenith Shinyzenith merged commit 7934fd2 into waycrate:freeze-feat-andreas Jun 18, 2024
3 checks passed
@Gigas002
Copy link
Author

Hey, @Shinyzenith! Thanks for reviewing this :)
Separation of #104 indeed seems a bit complicated to me, since I'm not sure my decisions will be met good by the maintainer's team, so I will be glad if you'd help me with it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants