Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] add argument to ignore devices #245

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aadilshabier
Copy link
Contributor

@aadilshabier aadilshabier commented Feb 27, 2024

Implement #137
--ignoredevice takes the same format as --device and ignores the devices listed, separated by semicolon. If a device is listed both in the --device argument and --ignoredevice argument, it is not added.

@Shinyzenith
Copy link
Member

Hi before I review this I notice that no documentation was added. Would you mind documenting the flags you're adding?

@Shinyzenith
Copy link
Member

CC: @zubairmh can you review this PR?

swhkd/src/daemon.rs Outdated Show resolved Hide resolved
Shinyzenith
Shinyzenith previously approved these changes Feb 28, 2024
@Shinyzenith
Copy link
Member

I'll wait on zubairs review too, if he doesn't respond by today, I'll merge it.

@Shinyzenith
Copy link
Member

Hi, I would like to merge this, can you kindly rebase this? My apologies for the delay.

--ignoredevice takes the same format as --device and ignores the devices
listed, separated by semicolon. If a device is listed both in the --device
argument and --ignoredevice argument, it is not added.

Also replaced default name from "" to "[unknown]" to prevent devices
without valid names from being matched by empty device arguments.
@aadilshabier
Copy link
Contributor Author

Hi, I would like to merge this, can you kindly rebase this? My apologies for the delay.

Done

id3v1669 added a commit to id3v1669/swhkd that referenced this pull request Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants