Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Key release events no longer wrongly swallowed by swhkd #167

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Commits on Oct 19, 2022

  1. [fix] Key release events no longer wrongly swallowed by swhkd

    In some cases, key release events for non-modifier keys are swallowed by swhkd.
    
    Given a simple modifier+key keybinding (ctrl+p for instance): when first
    pressing a key (p in this example) without a modifier, a key press event is sent
    to the virtual device to be consumed by other libraries and applications.
    Pressing the modifier key afterwards triggers the hotkey as expected. Releasing
    only the key at this point does not send a key release event to the virtual
    output, as the event_in_hotkeys boolean is true (control is still being pressed
    and control + p is mapped to a hotkey after all). To any library afterwards, the
    key is still being pressed as no release event has been received.
    
    To fix this issue, this changes the event_in_hotkey boolean to check for each
    hotkey if both the event and the hotkey are of the same type. This means that
    swhkd no longer swallows key press events if a matching hotkey triggers on key
    release only and it no longer swallows key release events if a matching hotkey
    triggers on key presses.
    ajanon committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    1a51ee3 View commit details
    Browse the repository at this point in the history