Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge in NOAA develop head #14

Open
wants to merge 41 commits into
base: sofar-develop
Choose a base branch
from
Open

Merge in NOAA develop head #14

wants to merge 41 commits into from

Conversation

camilleanne
Copy link

replaces #13

ukmo-ccbunney and others added 30 commits July 7, 2023 19:54
@ukmo-ccbunney
Bugfix - initialised VD and VS to zero in w3srcemd. (NOAA-EMC#1037)
17a4e32
@ukmo-ccbunney
More efficient test for binary files in matrix.comp (NOAA-EMC#1035)
2514633
@ukmo-ccbunney
Tidy up of pre-processor directives and unused variables in w3srcemd.…
4d8c315 
…F90 (NOAA-EMC#1010)
@ukmo-ccbunney
Correct typo in w3srcemd.F90 pre-processor directive. (NOAA-EMC#1039)
02cb72f
@mickaelaccensi
minor bugfix for matrix grepping on keywords (NOAA-EMC#1049)
1cacc43
@benoitp-cmc
Stop masking group 1 output where icec > icen (NOAA-EMC#1019)
dcafc8c
@MatthewMasarik-NOAA
Doxygen documentation added, 8th subset.(NOAA-EMC#1046)
2715a9e
@Ghazal-Mohammadpour
NC4 ,F90 ,XX0 switches removed from ww3_tp2.19 regtest (NOAA-EMC#1054)
b810a89
@MatthewMasarik-NOAA
CI: Fix for Intel scripts. GNU scripts updated. (NOAA-EMC#1064)
991daf8
@mickaelaccensi
correct the computation of QP parameter, add QKK output parameter, ch…
6b9edfa 
…ange UST scale factor (NOAA-EMC#1050)
@mickaelaccensi
correct issue with ww3_multi when requesting restart2 and using nml f…
8589d12 
…ile instead of inp file (NOAA-EMC#1070)
@mickaelaccensi
correct calendar for track netcdf output (NOAA-EMC#1079)
7bbdaca
@ukmo-ccbunney
Fix missing mod_def.ww3 file in multigrid regression tests for track …
b1356dd 
…output (NOAA-EMC#1091)
@MatthewMasarik-NOAA
STAB3: fix cmake build for ST4 or ST3 (NOAA-EMC#1086)
d22b7bb
@mickaelaccensi
new feature to output out_grd.ww3, out_pnt.ww3 and mod_def.ww3 both i…
eff6686 
…n binary and ascii format using switch ASCII. (NOAA-EMC#1089)
@ukmo-ccbunney
Update local unit number arrays (NDS, MDS) to be same size of array d…
d148d09 
…efined in w3odatmd (size=15). Also, defined unit numbers for NDS(14) and NDS(15). (NOAA-EMC#1098)
@ukmo-ccbunney
Removed code referencing PHIOC in output section for PHICE in ww3_ounf (
66262f6 
NOAA-EMC#1093)
@mickaelaccensi
implementation of the GQM (Gaussian Quadrature Method) to replace the…
8eb3596 
… DIA in NL1 or NL2. (NOAA-EMC#1083)
@JessicaMeixner-NOAA
update logic to ensure you are not accessing uninitialized dates (NOA…
4cd995d 
…A-EMC#1114)
@ukmo-ccbunney
Initialised S and D arrays in W3SDB1 before potential early return if…
c3451a9 
… zero energy. (NOAA-EMC#1115)
@Biao-Zhao
ww3_ounp.F90: x/y units attribute corrected from 'm' to 'km' (NOAA-EM…
f702a8f 
…C#1088)
@ukmo-ccbunney
Bugfix: Assign unit numbers to ASCII gridded/point output in multi-gr…
1f928aa 
…id mode. (NOAA-EMC#1118)
@mickaelaccensi
correct bugs to run correctly GQM implementation (NOAA-EMC#1127)
d90078b
@edwardhartnett
Adding documentation to w3iopo() in preparation for code for NOAA-EMC…
3f35df7 
…#682. (NOAA-EMC#1131)
@MatthewMasarik-NOAA
NCEP regtest module updates: uses spack-stack/1.5.0, includes scotch/…
ff1b9e9 
…7.0.4 (NOAA-EMC#1137)
@JessicaMeixner-NOAA
Minor update to ncep regtests (NOAA-EMC#1138)
d3ea810
@edwardhartnett
Updated intel workflow to install oneapi compilers from new location. (…
88c89be 
…NOAA-EMC#1157)
@edwardhartnett
Add unit test for points I/O code. (NOAA-EMC#1158)
7bec560
@AlexanderRichert-NOAA
Update Intel CI (relocate /usr/local; ensure intel-oneapi-mpi; use ub…
63f8270 
…untu-latest) (NOAA-EMC#1161)
@mickaelaccensi
remove lookup table for ST4 to speed up computation and clean up the …
3952826 
…ST4 code (NOAA-EMC#1124)

Co-authored-by: Fabrice Ardhuin <[email protected]>
JessicaMeixner-NOAA and others added 10 commits January 22, 2024 11:43
@JessicaMeixner-NOAA
initialize USSP_WN for mod_def (NOAA-EMC#1165)
026fcdd
@ErickRogers
Introduce IC4M8 and IC4M9 to WW3 (NOAA-EMC#1176)
9a718fc
@mickaelaccensi
clean up and add ST4 variables (NOAA-EMC#1181)
ff0358a
@MatthewMasarik-NOAA
w3fld1md.F90: fix divide by zero in CRIT2 parameter (NOAA-EMC#1184)
ba5cd68
@MatthewMasarik-NOAA
ww3_prnc.F90: fix out-of-scope grid index write statement (NOAA-EMC#1185
fd6d559 
)
@MatthewMasarik-NOAA @DeniseWorthen
Bugfix: address potential divide-by-zero in APPENDTAIL (NOAA-EMC#1188)
6d42025 
Co-authored-by: Denise Worthen <[email protected]>
@ukmo-ccbunney
Provide initial drying of cells with depth < ZLIM for SMC grid. (NOAA…
e085bcf 
…-EMC#1192)
@ukmo-ccbunney @JessicaMeixner-NOAA
Output OMP threading info to screen when running ww3_shel/ww3_multi c…
156a46d 
…ompiled with the OMPG switch. Also fixes truncation of build.log when running run_cmake_build. (NOAA-EMC#1191)

* Added screen output showing number of threads when OMP enabled.

* update build to get more info in logs (NOAA-EMC#46)

---------

Co-authored-by: Jessica Meixner <[email protected]>
@JessicaMeixner-NOAA
update run_cmake_test to catch build errors and exit (NOAA-EMC#1194)
9d3799f
@camilleanne
Merge branch 'develop' of https://github.com/NOAA-EMC/WW3 into ct/mer…
027ef77 
…ge-noaa-develop-2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelsolanocordoba miguelsolanocordoba Awaiting requested review from miguelsolanocordoba

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.