Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move follow button under the avatar #45

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

plrcgrss
Copy link

This pull request fixes issue #41

@DaniruKun DaniruKun self-requested a review October 16, 2024 20:15
@DaniruKun
Copy link
Member

Thanks! A couple small comments:

  1. I would probably make the follow button a bit smaller:
    image

For example, on smaller phones like an iPhone 12, there is basically no space left, so we should compensate for that a bit until it looks right:

image

  1. Same goes for the guest user view: we need to think how to fit this better,
    image

@plrcgrss
Copy link
Author

Hey @DaniruKun thanks for you Feedback! Would love to fix the size from the button.

@DaniruKun
Copy link
Member

@plrcgrss is better, for now it is fine in authenticated views
However, we should fit stuff better when viewing passes anonymously:
image

Some ideas:

  • Change font size and style to use less space for the button, change copy to "Sign up"
  • Change text "Login or Signup to follow" size or remove completely?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants