Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User defined imports name mangling #1865

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions waspc/data/Generator/templates/server/src/dbSeed.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@
import { prisma, DbSeedFn } from 'wasp/server'

{=# dbSeeds =}
{=& importStatement =}
{=& seedFn.importStatement =}
{=/ dbSeeds =}

const seeds = {
{=# dbSeeds =}
{= importIdentifier =},
{= name =}: {= seedFn.importIdentifier =},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we reference the import name in the CLI, we had to adjust the code a bit.

{=/ dbSeeds =}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,10 @@ export type { MiddlewareConfig, MiddlewareConfigFn } from 'wasp/server/middlewar

{=# globalMiddlewareConfigFn.isDefined =}
{=& globalMiddlewareConfigFn.importStatement =}
const globalMiddlewareConfigFn = {= globalMiddlewareConfigFn.importIdentifier =}
{=/ globalMiddlewareConfigFn.isDefined =}
{=^ globalMiddlewareConfigFn.isDefined =}
const {=& globalMiddlewareConfigFn.importAlias =} = (mc: MiddlewareConfig) => mc
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for a custom alias anymore 😄

const globalMiddlewareConfigFn = (mc: MiddlewareConfig) => mc
{=/ globalMiddlewareConfigFn.isDefined =}

// This is the set of middleware Wasp supplies by default.
Expand All @@ -29,7 +30,7 @@ const defaultGlobalMiddlewareConfig: MiddlewareConfig = new Map([

// This is the global middleware that is the result of applying the user's modifications.
// It will be used as the basis for Operations and APIs (unless they are further customized).
const globalMiddlewareConfig: MiddlewareConfig = {=& globalMiddlewareConfigFn.importAlias =}(defaultGlobalMiddlewareConfig)
const globalMiddlewareConfig: MiddlewareConfig = globalMiddlewareConfigFn(defaultGlobalMiddlewareConfig)

// This function returns an array of Express middleware to be used by a router. It optionally
// accepts a function that can modify the global middleware for specific route customization.
Expand Down
26 changes: 13 additions & 13 deletions waspc/data/Generator/templates/server/src/routes/apis/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,32 +9,32 @@ import { type AuthUser } from 'wasp/auth'
{=/ isAuthEnabled =}

{=# apiNamespaces =}
{=& namespaceMiddlewareConfigFnImportStatement =}
{=& namespaceMiddlewareConfigFn.importStatement =}
{=/ apiNamespaces =}

{=# apiRoutes =}
{=& importStatement =}
{=& apiRouteFn.importStatement =}
{=# routeMiddlewareConfigFn.isDefined =}
{=& routeMiddlewareConfigFn.importStatement =}
{=/ routeMiddlewareConfigFn.isDefined =}
{=/ apiRoutes =}

const idFn: MiddlewareConfigFn = x => x

{=# apiRoutes =}
{=^ routeMiddlewareConfigFn.isDefined =}
const {=& routeMiddlewareConfigFn.importAlias =} = idFn
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for custom aliases anymore, rewrote this code to work with the new mangling.

{=/ routeMiddlewareConfigFn.isDefined =}
{=/ apiRoutes =}

const router = express.Router()

{=# apiNamespaces =}
router.use('{= namespacePath =}', globalMiddlewareConfigForExpress({= namespaceMiddlewareConfigFnImportAlias =}))
router.use('{= namespacePath =}', globalMiddlewareConfigForExpress({= namespaceMiddlewareConfigFn.importIdentifier =}))
{=/ apiNamespaces =}

{=# apiRoutes =}
const {= apiName =}Middleware = globalMiddlewareConfigForExpress({= routeMiddlewareConfigFn.importAlias =})
{=# routeMiddlewareConfigFn.isDefined =}
const {= apiName =}Middleware = globalMiddlewareConfigForExpress({= routeMiddlewareConfigFn.importIdentifier =})
{=/ routeMiddlewareConfigFn.isDefined =}
{=^ routeMiddlewareConfigFn.isDefined =}
const {= apiName =}Middleware = globalMiddlewareConfigForExpress(idFn)
{=/ routeMiddlewareConfigFn.isDefined =}

router.{= routeMethod =}(
'{= routePath =}',
{=# usesAuth =}
Expand All @@ -45,8 +45,8 @@ router.{= routeMethod =}(
{=/ usesAuth =}
handleRejection(
(
req: Parameters<typeof {= importIdentifier =}>[0]{=# usesAuth =} & { user: AuthUser }{=/ usesAuth =},
res: Parameters<typeof {= importIdentifier =}>[1],
req: Parameters<typeof {= apiRouteFn.importIdentifier =}>[0]{=# usesAuth =} & { user: AuthUser }{=/ usesAuth =},
res: Parameters<typeof {= apiRouteFn.importIdentifier =}>[1],
) => {
const context = {
{=# usesAuth =}
Expand All @@ -58,7 +58,7 @@ router.{= routeMethod =}(
{=/ entities =}
},
}
return {= importIdentifier =}(req, res, context)
return {= apiRouteFn.importIdentifier =}(req, res, context)
}
)
)
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading