RISCV: lui: properly sign extend on rv64 and rv32 #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wargio
reviewed
Jun 28, 2023
Comment on lines
+193
to
+196
| var imm = parseInt(instr.parsed.opd[1]); | ||
| var imm20 = imm << 12; | ||
| var n = new Long(imm20, ((Global.evars.archbits > 32) && imm & 0x80000) ? -1 : 0, true); | ||
| return Base.assign(dst, '0x' + n.toString(16)) ; |
There was a problem hiding this comment.
Yes. Forgive naive code. With current HEAD I get:
lui a4, 0xff880 | a4 = 0xffffffffffffffff;
addi a4, a4, -1
which is kinda annoying. I tried to fix it by various C-like means, but I always got 0 at imm20 stage, so I had to resort to throwing new Long object to make it simply work.
|
any update here? |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick but working fix. Tested both rv32 and rv64 (on rv32 simply ignored).
Feel free to edit to match your code (I'm noob at js)