Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing arches to cross-compilation #120

Closed
wants to merge 4 commits into from

Conversation

ctrlcctrlv
Copy link

No way to build on Ubuntu if you don't even have arm64/amd64 Linux builds :-)

@walles
Copy link
Owner

walles commented Jan 22, 2023

Which of these architecture combos do you personally need right now?

@walles walles closed this in 053e354 Jan 22, 2023
@walles
Copy link
Owner

walles commented Jan 22, 2023

Does 053e54 resolve your problem?

No way to build on Ubuntu if you don't even have arm64/amd64 Linux builds :-)

@ctrlcctrlv
Copy link
Author

No? Why are you against building the arches people need?

@ctrlcctrlv
Copy link
Author

If you, the upstream, do not distribute a 64-bit binary for Linux at all, but weirdly do distribute i386, it's pretty difficult to convince maintainers of package repositories that the project is serious enough to be included. And since this is a Go project for a PPA the easiest thing for me to do would be to just wrap your binary? I don't get why you closed this.

@walles
Copy link
Owner

walles commented Jan 22, 2023

I seem to have mis-interpreted your intention with this PR, sorry about that.

Based on your initial PR comment I assumed that the problem you wanted solved was this:

  • Being able to run test.sh on any arch

That is now solved by 053e354.

But that seems to have been a mis-interpretation on my part.

Which problem is it that you want solved?

  • Being able to wrap moar in binary-only .debs for various platforms in a PPA?
  • Being able to make a source based .deb for this?
  • ... something else?

The reasoning behind i386 is that that single binary will work on both x64 and i386. Not sure how well it holds up though, do you have any counter example?

AFAIR, I started out with an x64 Linux binary, but then I ended up in some 32 bit Docker image and was unable to run moar there. So I decided on one binary for both platforms.

But as you're hinting at, maybe I should have an x64 binary for Linux for marketing reasons, whether that's strictly needed or not.

Regards /Johan

@walles walles reopened this Jan 22, 2023
arches.sh Outdated Show resolved Hide resolved
Comment on lines +15 to +16
echo " Windows 386..."
GOOS=windows GOARCH=386 ./build.sh
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is anybody running Windows 386?

If not I'd prefer not supplying binaries for it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have heard it tends to be lighter weight in virtual machines and most projects I work on continue to support it but I don't mind dropping the line.

arches.sh Outdated Show resolved Hide resolved
@walles
Copy link
Owner

walles commented Feb 18, 2023

First of all, I apologize for my slow response time here :(.

But regarding this:

for a PPA the easiest thing for me to do would be to just wrap your binary

Binary PPAs seem not to be allowed: "Note: We do not allow uploading pre-built binary packages."

Not sure I found the right one though, but reading on, what that guide wants is for you to "Create your source package, upload it and Launchpad will build binaries and then host them in your own apt repository."

Are these the instructions you're following, or did you find some others that do allow for packaging binaries?

@walles
Copy link
Owner

walles commented Feb 22, 2023

Tagging with Debian packaging since if this had been Debian packaged you'd already have had it in Ubuntu:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=944035

@walles
Copy link
Owner

walles commented Jul 8, 2023

It seems like #137 is the goal here, closing in favor of that one.

@walles walles closed this Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants