Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(libwaku): add protected shard #3211

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(libwaku): add protected shard #3211

wants to merge 2 commits into from

Conversation

richard-ramos
Copy link
Member

@richard-ramos richard-ramos commented Dec 16, 2024 •
edited by Ivansete-status
Loading

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 16, 2024 •
edited
Loading

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3211

Built from 20532a2

@gabrielmer
Copy link
Contributor

Thanks so much!

Random question - shouldn't we keep with the "protected-shard" naming and input cluster and shard instead of topic for consistency?
Not sure if that would give trouble from status-go side, I guess it's just a matter of reformatting the input, but it would make libwaku and nwaku consistent

@richard-ramos
Copy link
Member Author

Random question - shouldn't we keep with the "protected-shard" naming and input cluster and shard instead of topic for consistency?
Not sure if that would give trouble from status-go side, I guess it's just a matter of reformatting the input, but it would make libwaku and nwaku consistent

Sounds like a good idea. Will do that change

@richard-ramos richard-ramos mentioned this pull request Dec 17, 2024
Open
28 tasks
gabrielmer
gabrielmer approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

@richard-ramos richard-ramos changed the title feat(libwaku): add protected topic feat(libwaku): add protected shard Dec 17, 2024
Ivansete-status
Ivansete-status approved these changes Dec 23, 2024
View reviewed changes
Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for it! 💯
I just added a nitpick suggestion

library/waku_thread/inter_thread_communication/requests/protocols/relay_request.nim
@[protectedShard], uint16(self.clusterId)
)
except ValueError:
return err(getCurrentExceptionMsg())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return err(getCurrentExceptionMsg())
return err("ADD_PROTECTED_SHARD exception: " & getCurrentExceptionMsg())

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ivansete-status Ivansete-status Ivansete-status approved these changes

@gabrielmer gabrielmer gabrielmer approved these changes

@darshankabariya darshankabariya Awaiting requested review from darshankabariya

@NagyZoltanPeter NagyZoltanPeter Awaiting requested review from NagyZoltanPeter

Assignees

@richard-ramos richard-ramos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richard-ramos @gabrielmer @Ivansete-status