chore: adding new job in the CI.yml file #3193
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at Built from d0ecc16 |
fbarbu15
reviewed
Dec 5, 2024
.github/workflows/ci.yml
Outdated
| @@ -126,6 +126,15 @@ jobs: | |||
| uses: waku-org/nwaku/.github/workflows/container-image.yml@master | |||
| secrets: inherit | |||
|
|
|||
| QA_tests: | |||
There was a problem hiding this comment.
let's name it somthing more suggestive, ex:
nwaku-nwaku-interop-tests
because we will also have at some point
nwaku-gowaku-interop-tests
.github/workflows/ci.yml
Outdated
| @@ -126,6 +126,15 @@ jobs: | |||
| uses: waku-org/nwaku/.github/workflows/container-image.yml@master | |||
| secrets: inherit | |||
|
|
|||
| QA_tests: | |||
| needs: build-docker-image | |||
| uses: waku-org/waku-interop-tests/.github/workflows/nim_waku_PR.yml@smoke_tests | |||
There was a problem hiding this comment.
please don't forget to update the branch when the interop PR get's merged to master
Ivansete-status
changed the title
|
@AYAHASSAN287 : Please add one or more reviewers from nwaku team. We need at least two approval to be able to merge. |
.github/workflows/ci.yml
Outdated
| @@ -126,6 +126,15 @@ jobs: | |||
| uses: waku-org/nwaku/.github/workflows/container-image.yml@master | |||
| secrets: inherit | |||
|
|
|||
| QA_tests: | |||
| needs: build-docker-image | |||
| uses: waku-org/waku-interop-tests/.github/workflows/nim_waku_PR.yml@master | |||
There was a problem hiding this comment.
Instead of using master I think it is better to use a fixed tag so that the changes in your master doesn't impact our CI :)
Ivansete-status
requested review from
darshankabariya,
gabrielmer and
NagyZoltanPeter
fbarbu15
reviewed
Dec 16, 2024
.github/workflows/ci.yml
Outdated
| @@ -126,6 +126,15 @@ jobs: | |||
| uses: waku-org/nwaku/.github/workflows/container-image.yml@master | |||
| secrets: inherit | |||
|
|
|||
| nwaku-nwaku-interop-tests: | |||
| needs: build-docker-image | |||
| uses: waku-org/waku-interop-tests/.github/workflows/nim_waku_PR.yml@SMOKE_TESTS | |||
There was a problem hiding this comment.
do we have such branch on waku-interop-tests side?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this is temp branch to test new workflow
Changes