-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing directory and file Ignore for dev command #2676
base: master
Are you sure you want to change the base?
Conversation
@Ironpark - I'm happy to move ahead with this. Are you able to |
@leaanthony Updated some missing code and the changelog :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this 👍 Sorry, I realised I should have asked you to update a couple of other files too! 😅
I just updated the config.v2.json, project-config.mdx files. "ignore": {
"type": "array",
"description": "Specifies a matching folder or file path that should not trigger a reload when changed. Each pattern follows gitignore's matching rules.",
"examples": [
["*_test.go", "/cmd/cli/*.go"]
]
} |
Bah, I'm really sorry this has slipped so far. If you are keen to get this in, could you please resolve the conflict and we'll get this merged in |
@Ironpark - ping |
Description
#1031
When using the Dev command, you may not want to trigger a rebuild when a file or directory changes that are not related to the app
In project, already using the github.com/sabhiram/go-gitignore package, so I use it, so the syntax is the same as that of gitignore.
Does have any other thoughts on that implementation, or a problem sword? @leaanthony