Skip to content

Commit

Permalink
Simplify function by removing required argument
Browse files Browse the repository at this point in the history
  • Loading branch information
KalobTaulien authored and gasman committed Jun 23, 2020
1 parent d4eb472 commit 45ef406
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions wagtail_transfer/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,8 @@ def choose_page(request):
})


def import_missing_object_data(source, base_url, importer: ImportPlanner):
def import_missing_object_data(source, importer: ImportPlanner):
base_url = settings.WAGTAILTRANSFER_SOURCES[source]['BASE_URL']
while importer.missing_object_data:
# convert missing_object_data from a set of (model_class, id) tuples
# into a dict of {model_class_label: [list_of_ids]}
Expand Down Expand Up @@ -230,7 +231,7 @@ def import_page(request):
dest_page_id = request.POST['dest_page_id'] or None
importer = ImportPlanner.for_page(source=request.POST['source_page_id'], destination=dest_page_id)
importer.add_json(response.content)
importer = import_missing_object_data(source, base_url, importer)
importer = import_missing_object_data(source, importer)

if dest_page_id:
return redirect('wagtailadmin_explore', dest_page_id)
Expand All @@ -252,7 +253,7 @@ def import_model(request):
response = requests.get(url, params={'digest': digest})
importer = ImportPlanner.for_model(model=model)
importer.add_json(response.content)
importer = import_missing_object_data(source, base_url, importer)
importer = import_missing_object_data(source, importer)

messages.add_message(request, messages.SUCCESS, 'Snippet(s) successfully imported')
app_label, model_name = model.split('.')
Expand Down

0 comments on commit 45ef406

Please sign in to comment.