Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a machine translation option when sycning pages #807

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

waldo90
Copy link

@waldo90 waldo90 commented Jun 19, 2024

This PR adds an option for machine translation to be performed when synicing page translations as per issue:
#786

It adds the option alongside the existing 'publish immediately' option as I found that these can be made to work togther in all combinations:

  • sync only
  • sync and publish without machine translation
  • sync and publish with machine tranlation
  • sync with machine translation (unpublished but ready for review)

This is slightly as odds with what was discussed on the ticket. However, I'm hopeful that the extra flexibility will be welcome.

Copy link
Collaborator

@zerolab zerolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great start @waldo90

Left a few notes and suggestions for improvement

wagtail_localize/views/update_translations.py Show resolved Hide resolved
wagtail_localize/views/update_translations.py Show resolved Hide resolved
wagtail_localize/views/edit_translation.py Outdated Show resolved Hide resolved
@waldo90 waldo90 requested a review from zerolab September 5, 2024 10:10
@waldo90
Copy link
Author

waldo90 commented Oct 7, 2024

Hi @zerolab, just a wee heads up that this is ready for review again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants