Escape all shell special characters #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wader
reviewed
Nov 25, 2024
| def sh_escape: | ||
| if . == "" or test("['\" $\n\\\\()]") then | ||
| if . == "" or test("[^[A-Za-z0-9%+\\-./:=@_]]") then |
There was a problem hiding this comment.
👍 yeap that feels safer. that stackoverflow response is quite impressive!
|
Turned out it didn't work as intended and took me embarrassingly long time to see what was wrong :) fixed in 482c422 |
|
Oops. Sorry, I didn't test it locally since it looked right. I assumed it would be caught with CI |
|
No worries 👍 sadly the current |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows only characters which don't require quoting. I realized I was thinking about only the characters used in what's conceptually a string, but there's many more. I consulted https://stackoverflow.com/questions/15783701/which-characters-need-to-be-escaped-when-using-bash/27817504#27817504, which derives its list from what needs escaping with
${var@Q}.