Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External evaluation of Diffy Chat milestone 2 #913

Merged
merged 11 commits into from
Jul 20, 2023

Conversation

dastansam
Copy link
Contributor

@dastansam dastansam commented Jul 7, 2023

I wasn't able to reproduce actions from the tutorial video. More on this in the evaluation file.

Application: https://github.com/w3f/Grants-Program/blob/master/applications/Diffy_chat.md
Milestone delivery PR: #912

@dastansam dastansam marked this pull request as ready for review July 7, 2023 17:46
@keeganquigley keeganquigley self-assigned this Jul 11, 2023
@dastansam dastansam mentioned this pull request Jul 12, 2023
6 tasks
@keeganquigley
Copy link
Contributor

keeganquigley commented Jul 14, 2023

I am experiencing the same lag issues. I also have trouble when I close the window and re-open it to register a new user. It seems to stick and not do anything.

In the chat app, I was never quite able to establish 2-way communication. It keeps asking to allow connection to undefined. Also, it doesn't seem to switch chat windows when clicking on the different users in the contact list.

Regarding entering the mnemonic phrase, as @dastansam mentioned, a user should never have to enter it into an app. I'm assuming that's just for test purposes, correct? Do you plan to integrate wallet functionality in the full product?

diffy lag

@dastansam
Copy link
Contributor Author

hey @keeganquigley,

@beoblock addressed the lag issues and I was able to confirm changes were made and they fix the issues from evaluation v1. I updated the evaluation file with new screenshots and changed the status to Accepted

@keeganquigley
Copy link
Contributor

Thanks @dastansam looks great as usual. I will forward your payment to the operations team.

@keeganquigley keeganquigley merged commit eec3169 into w3f:master Jul 20, 2023
3 checks passed
@dastansam dastansam deleted the diffychat-evaluation branch July 22, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants