T6961: package-build: Fix kea build race condition #865
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Fix a race condition in the
kea
package build process.Types of changes
Related Task(s)
https://vyos.dev/T6961
Component(s) name
package-build (
kea
)Proposed changes
Because the
package.toml
file for thekea
package doesn't specify a build command, it defaults to runningdpkg-buildpackage -uc -us -tc -F
against the clonedgit
repo. This is a problem because, by default,dpkg-buildpackage
runs tasks in parallel (the limit is defined asauto
, but seems to be based off the number of processors the system has), and there's a component being compiled inkea
that other make tasks rely on, but ends up sometimes not being built in time for the dependent task to run successfully.This PR adds a build command to kea's package.toml that specifies the additional argument
-j 1
to the originaldpkg-buildpackage
command, which revertsdpkg-buildpackage
's behaviour to serial execution of tasks.How to test
Checklist: