Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ids: T6919: remove Fastnetmon from the base system #4214

Open
wants to merge 1 commit into
base: current
Choose a base branch
from

Conversation

dmbaturin
Copy link
Member

Change Summary

Remove Fastnetmon from the base system. It will eventually be moved to an addon.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe): feature removal.

Related Task(s)

Related PR(s)

Component(s) name

IDS.

Proposed changes

There is no deep integration into the firewall subsystem for Fastnetmon and there doesn't seem to be any interest in improving the VyOS integration from its maintainers. If it's not getting a deep integration, it's better to move it to an optional addon.

How to test

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

It will eventually be moved to an addon
Copy link

github-actions bot commented Dec 2, 2024

👍
No issues in PR Title / Commit Title

Copy link

github-actions bot commented Dec 2, 2024

CI integration ❌ failed!

Details

CI logs

  • CLI Smoketests (no interfaces) ❌ failed
  • CLI Smoketests (interfaces only) ❌ failed
  • Config tests ❌ failed
  • RAID1 tests ❌ failed
  • TPM tests ❌ failed

@sever-sever
Copy link
Member

I’m disagree with this decision.
At least until we do not have addon.
And I do not see any alternative options for this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants