This repository has been archived by the owner on Dec 2, 2019. It is now read-only.
demo/glfw_opengl3 Remove global state #760
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Embedd the GLFW state structure as a user pointer in the window * For the callbacks, point to the GLFW state using nk_handle.ptr
* This should prevent segfaults when compiling w/ -O2 and defining INCLUDE_ALL
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Its great that Nuklear doesn't depend on globals.
However, some of the demos do. This could be a problem if we want to create multiple windows with their own, separate states/contexts. (e.g. #451)
This PR is an attempt to get rid of the global state for the
glfw_opengl3demo.EDIT: I forgot to mention that: