feat: add upload functionality in the middleware #7323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cb75088 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bartoszherba
requested review from
sethidden,
WojtekTheWebDev,
a team and
jagoral
and removed request for
a team and
sethidden
jagoral
reviewed
Nov 21, 2024
jagoral
reviewed
Nov 21, 2024
packages/middleware/__tests__/integration/bootstrap/serverWithUpload.ts
Outdated
Show resolved
Hide resolved
jagoral
reviewed
Nov 21, 2024
jagoral
reviewed
Nov 21, 2024
jagoral
reviewed
Nov 21, 2024
jagoral
reviewed
Nov 21, 2024
jagoral
reviewed
Nov 21, 2024
| * Configuration options for handling file uploads. | ||
| * @see FileUploadOptions | ||
| */ | ||
| fileUpload?: FileUploadOptions; |
There was a problem hiding this comment.
it could be great if we achieved an option to set the config based on the request
Suggested change
| fileUpload?: FileUploadOptions; | |
| fileUpload?: FileUploadOptions | (req: Request) => FileUploadOptions; |
I believe user may create multiple endpoints for file upload, and some of them may differ for instance in allowedMimeTypes or maximum number of files
jagoral
reviewed
Nov 21, 2024
bartoszherba
force-pushed
the
feat/add-file-upload-handling
branch
from
998eacc to
4f3dced
Compare
lsliwaradioluz
approved these changes
Nov 22, 2024
bartoszherba
force-pushed
the
feat/add-file-upload-handling
branch
from
4f3dced to
cb75088
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The issue involves enhancing the middleware express app by allowing the addition of multiple body parsers. Currently, only the JSON body parser is available, which limits functionality for developers needing to implement file uploads.
Context
The middleware express app is currently configured to use only a JSON body parser. This restriction poses challenges for developers who require different body parsers for specific functionalities, such as file uploads.