Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(IN-3538): orchestration #6965

Merged
merged 33 commits into from
Oct 5, 2023
Merged

feat(IN-3538): orchestration #6965

merged 33 commits into from
Oct 5, 2023

Conversation

WojtekTheWebDev
Copy link
Collaborator

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSDoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Add orchestration possibility by extending the context with integrations and getIntegration properties.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@WojtekTheWebDev WojtekTheWebDev requested a review from a team September 25, 2023 18:12
michaelKurowski
michaelKurowski approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@michaelKurowski michaelKurowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its ok from my side but check tests firsts as you have breaking change in types.

@WojtekTheWebDev WojtekTheWebDev changed the title feat: orchestration feat(IN-3538): orchestration Sep 28, 2023
Fifciu
Fifciu approved these changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@Fifciu Fifciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicks to add to batch and commit, looks good. Great work Wojtek

docs/content/3.middleware/2.guides/4.orchestration.md Outdated Show resolved Hide resolved
docs/content/3.middleware/2.guides/4.orchestration.md Outdated Show resolved Hide resolved
packages/middleware/src/createServer.ts Show resolved Hide resolved
bartoszherba
bartoszherba reviewed Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@bartoszherba bartoszherba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WojtekTheWebDev Are we going to build changelog based on the changeset messages? Because these messages are meaningless.

@WojtekTheWebDev
Copy link
Collaborator Author

@bartoszherba Yeah I know, I'm going to fix it as soon as I'll close the prerelease mode to not do it twice

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2023

[vuestorefront_vue-storefront_sdk] Kudos, SonarCloud Quality Gate passed!Β  Β  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2023

[vuestorefront_vue-storefront_cli] Kudos, SonarCloud Quality Gate passed!Β  Β  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2023

[vuestorefront_vue-storefront_middleware] Kudos, SonarCloud Quality Gate passed!Β  Β  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@WojtekTheWebDev WojtekTheWebDev merged commit 1caa56e into main Oct 5, 2023
9 checks passed
@WojtekTheWebDev WojtekTheWebDev deleted the feat/orchestration branch October 5, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartoszherba bartoszherba bartoszherba left review comments

@Fifciu Fifciu Fifciu approved these changes

@michaelKurowski michaelKurowski michaelKurowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@WojtekTheWebDev @michaelKurowski @bartoszherba @Fifciu @rohrig