Skip to content

Commit

Permalink
eslint-integrations: Use typescript-eslint that supports TypeScript 5.6
Browse files Browse the repository at this point in the history
Internal enterprise repo uses TypeScript 5.6 and we get (harmless) warnings that only TS 5.4 is supported by the eslint parser

See https://github.com/typescript-eslint/typescript-eslint/releases/tag/v8.10.0
  • Loading branch information
sethidden committed Nov 19, 2024
1 parent 011a009 commit c2abf0a
Show file tree
Hide file tree
Showing 6 changed files with 73 additions and 68 deletions.
5 changes: 5 additions & 0 deletions .changeset/curvy-spies-bow.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@vue-storefront/eslint-config-integrations": patch
---

Update to a typescript-eslint 8.10, which supports parsing Typescript 5.6, see https://github.com/typescript-eslint/typescript-eslint/releases/tag/v8.10.0
2 changes: 1 addition & 1 deletion engineering-toolkit/integrations-eslint/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ module.exports = {
"prettier/prettier": "error",
"no-unused-vars": "off",
"@typescript-eslint/no-unused-vars": ["error"],
"@typescript-eslint/ban-types": "warn",
"@typescript-eslint/no-restricted-types": "warn",
"no-underscore-dangle": "off",
"import/prefer-default-export": "off",
"import/extensions": [
Expand Down
4 changes: 2 additions & 2 deletions engineering-toolkit/integrations-eslint/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@
"access": "public"
},
"dependencies": {
"@typescript-eslint/eslint-plugin": "^7",
"@typescript-eslint/parser": "^7",
"@typescript-eslint/eslint-plugin": "^8.10",
"@typescript-eslint/parser": "^8.10",
"eslint": "^8.55.0",
"eslint-config-airbnb-base": "^15.0.0",
"eslint-config-prettier": "^8.8.0",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const copyEnv = async (vsfDirName: string, magentoDomain?: string) => {

fs.writeFileSync(path.join(vsfDirName, ".env"), result, "utf8");
}
} catch (error) {
} catch {
simpleLog(
"No .env file available. Please check that your git repository is a valid Vue Storefront project",
picocolors.red
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/src/utils/getPackageManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const checkPackageManager = async (
): Promise<boolean> => {
try {
await execa(packageManager, ["--version"], { stdio: "ignore" });
} catch (error) {
} catch {
return false;
}

Expand Down
126 changes: 63 additions & 63 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2525,16 +2525,16 @@
natural-compare "^1.4.0"
ts-api-utils "^1.3.0"

"@typescript-eslint/eslint-plugin@^7":
version "7.10.0"
resolved "https://registry.yarnpkg.com/@typescript-eslint/eslint-plugin/-/eslint-plugin-7.10.0.tgz#07854a236f107bb45cbf4f62b89474cbea617f50"
integrity sha512-PzCr+a/KAef5ZawX7nbyNwBDtM1HdLIT53aSA2DDlxmxMngZ43O8SIePOeX8H5S+FHXeI6t97mTt/dDdzY4Fyw==
"@typescript-eslint/eslint-plugin@^8.10":
version "8.15.0"
resolved "https://registry.yarnpkg.com/@typescript-eslint/eslint-plugin/-/eslint-plugin-8.15.0.tgz#c95c6521e70c8b095a684d884d96c0c1c63747d2"
integrity sha512-+zkm9AR1Ds9uLWN3fkoeXgFppaQ+uEVtfOV62dDmsy9QCNqlRHWNEck4yarvRNrvRcHQLGfqBNui3cimoz8XAg==
dependencies:
"@eslint-community/regexpp" "^4.10.0"
"@typescript-eslint/scope-manager" "7.10.0"
"@typescript-eslint/type-utils" "7.10.0"
"@typescript-eslint/utils" "7.10.0"
"@typescript-eslint/visitor-keys" "7.10.0"
"@typescript-eslint/scope-manager" "8.15.0"
"@typescript-eslint/type-utils" "8.15.0"
"@typescript-eslint/utils" "8.15.0"
"@typescript-eslint/visitor-keys" "8.15.0"
graphemer "^1.4.0"
ignore "^5.3.1"
natural-compare "^1.4.0"
Expand All @@ -2551,25 +2551,17 @@
"@typescript-eslint/visitor-keys" "8.13.0"
debug "^4.3.4"

"@typescript-eslint/parser@^7":
version "7.10.0"
resolved "https://registry.yarnpkg.com/@typescript-eslint/parser/-/parser-7.10.0.tgz#e6ac1cba7bc0400a4459e7eb5b23115bd71accfb"
integrity sha512-2EjZMA0LUW5V5tGQiaa2Gys+nKdfrn2xiTIBLR4fxmPmVSvgPcKNW+AE/ln9k0A4zDUti0J/GZXMDupQoI+e1w==
"@typescript-eslint/parser@^8.10":
version "8.15.0"
resolved "https://registry.yarnpkg.com/@typescript-eslint/parser/-/parser-8.15.0.tgz#92610da2b3af702cfbc02a46e2a2daa6260a9045"
integrity sha512-7n59qFpghG4uazrF9qtGKBZXn7Oz4sOMm8dwNWDQY96Xlm2oX67eipqcblDj+oY1lLCbf1oltMZFpUso66Kl1A==
dependencies:
"@typescript-eslint/scope-manager" "7.10.0"
"@typescript-eslint/types" "7.10.0"
"@typescript-eslint/typescript-estree" "7.10.0"
"@typescript-eslint/visitor-keys" "7.10.0"
"@typescript-eslint/scope-manager" "8.15.0"
"@typescript-eslint/types" "8.15.0"
"@typescript-eslint/typescript-estree" "8.15.0"
"@typescript-eslint/visitor-keys" "8.15.0"
debug "^4.3.4"

"@typescript-eslint/[email protected]":
version "7.10.0"
resolved "https://registry.yarnpkg.com/@typescript-eslint/scope-manager/-/scope-manager-7.10.0.tgz#054a27b1090199337a39cf755f83d9f2ce26546b"
integrity sha512-7L01/K8W/VGl7noe2mgH0K7BE29Sq6KAbVmxurj8GGaPDZXPr8EEQ2seOeAS+mEV9DnzxBQB6ax6qQQ5C6P4xg==
dependencies:
"@typescript-eslint/types" "7.10.0"
"@typescript-eslint/visitor-keys" "7.10.0"

"@typescript-eslint/[email protected]":
version "8.13.0"
resolved "https://registry.yarnpkg.com/@typescript-eslint/scope-manager/-/scope-manager-8.13.0.tgz#2f4aed0b87d72360e64e4ea194b1fde14a59082e"
Expand All @@ -2578,15 +2570,13 @@
"@typescript-eslint/types" "8.13.0"
"@typescript-eslint/visitor-keys" "8.13.0"

"@typescript-eslint/[email protected].0":
version "7.10.0"
resolved "https://registry.yarnpkg.com/@typescript-eslint/type-utils/-/type-utils-7.10.0.tgz#8a75accce851d0a331aa9331268ef64e9b300270"
integrity sha512-D7tS4WDkJWrVkuzgm90qYw9RdgBcrWmbbRkrLA4d7Pg3w0ttVGDsvYGV19SH8gPR5L7OtcN5J1hTtyenO9xE9g==
"@typescript-eslint/[email protected].0":
version "8.15.0"
resolved "https://registry.yarnpkg.com/@typescript-eslint/scope-manager/-/scope-manager-8.15.0.tgz#28a1a0f13038f382424f45a988961acaca38f7c6"
integrity sha512-QRGy8ADi4J7ii95xz4UoiymmmMd/zuy9azCaamnZ3FM8T5fZcex8UfJcjkiEZjJSztKfEBe3dZ5T/5RHAmw2mA==
dependencies:
"@typescript-eslint/typescript-estree" "7.10.0"
"@typescript-eslint/utils" "7.10.0"
debug "^4.3.4"
ts-api-utils "^1.3.0"
"@typescript-eslint/types" "8.15.0"
"@typescript-eslint/visitor-keys" "8.15.0"

"@typescript-eslint/[email protected]":
version "8.13.0"
Expand All @@ -2598,29 +2588,25 @@
debug "^4.3.4"
ts-api-utils "^1.3.0"

"@typescript-eslint/[email protected]":
version "7.10.0"
resolved "https://registry.yarnpkg.com/@typescript-eslint/types/-/types-7.10.0.tgz#da92309c97932a3a033762fd5faa8b067de84e3b"
integrity sha512-7fNj+Ya35aNyhuqrA1E/VayQX9Elwr8NKZ4WueClR3KwJ7Xx9jcCdOrLW04h51de/+gNbyFMs+IDxh5xIwfbNg==
"@typescript-eslint/[email protected]":
version "8.15.0"
resolved "https://registry.yarnpkg.com/@typescript-eslint/type-utils/-/type-utils-8.15.0.tgz#a6da0f93aef879a68cc66c73fe42256cb7426c72"
integrity sha512-UU6uwXDoI3JGSXmcdnP5d8Fffa2KayOhUUqr/AiBnG1Gl7+7ut/oyagVeSkh7bxQ0zSXV9ptRh/4N15nkCqnpw==
dependencies:
"@typescript-eslint/typescript-estree" "8.15.0"
"@typescript-eslint/utils" "8.15.0"
debug "^4.3.4"
ts-api-utils "^1.3.0"

"@typescript-eslint/[email protected]", "@typescript-eslint/types@^8.9.0":
version "8.13.0"
resolved "https://registry.yarnpkg.com/@typescript-eslint/types/-/types-8.13.0.tgz#3f35dead2b2491a04339370dcbcd17bbdfc204d8"
integrity sha512-4cyFErJetFLckcThRUFdReWJjVsPCqyBlJTi6IDEpc1GWCIIZRFxVppjWLIMcQhNGhdWJJRYFHpHoDWvMlDzng==

"@typescript-eslint/[email protected]":
version "7.10.0"
resolved "https://registry.yarnpkg.com/@typescript-eslint/typescript-estree/-/typescript-estree-7.10.0.tgz#6dcdc5de3149916a6a599fa89dde5c471b88b8bb"
integrity sha512-LXFnQJjL9XIcxeVfqmNj60YhatpRLt6UhdlFwAkjNc6jSUlK8zQOl1oktAP8PlWFzPQC1jny/8Bai3/HPuvN5g==
dependencies:
"@typescript-eslint/types" "7.10.0"
"@typescript-eslint/visitor-keys" "7.10.0"
debug "^4.3.4"
globby "^11.1.0"
is-glob "^4.0.3"
minimatch "^9.0.4"
semver "^7.6.0"
ts-api-utils "^1.3.0"
"@typescript-eslint/[email protected]":
version "8.15.0"
resolved "https://registry.yarnpkg.com/@typescript-eslint/types/-/types-8.15.0.tgz#4958edf3d83e97f77005f794452e595aaf6430fc"
integrity sha512-n3Gt8Y/KyJNe0S3yDCD2RVKrHBC4gTUcLTebVBXacPy091E6tNspFLKRXlk3hwT4G55nfr1n2AdFqi/XMxzmPQ==

"@typescript-eslint/[email protected]":
version "8.13.0"
Expand All @@ -2636,15 +2622,19 @@
semver "^7.6.0"
ts-api-utils "^1.3.0"

"@typescript-eslint/[email protected].0":
version "7.10.0"
resolved "https://registry.yarnpkg.com/@typescript-eslint/utils/-/utils-7.10.0.tgz#8ee43e5608c9f439524eaaea8de5b358b15c51b3"
integrity sha512-olzif1Fuo8R8m/qKkzJqT7qwy16CzPRWBvERS0uvyc+DHd8AKbO4Jb7kpAvVzMmZm8TrHnI7hvjN4I05zow+tg==
"@typescript-eslint/[email protected].0":
version "8.15.0"
resolved "https://registry.yarnpkg.com/@typescript-eslint/typescript-estree/-/typescript-estree-8.15.0.tgz#915c94e387892b114a2a2cc0df2d7f19412c8ba7"
integrity sha512-1eMp2JgNec/niZsR7ioFBlsh/Fk0oJbhaqO0jRyQBMgkz7RrFfkqF9lYYmBoGBaSiLnu8TAPQTwoTUiSTUW9dg==
dependencies:
"@eslint-community/eslint-utils" "^4.4.0"
"@typescript-eslint/scope-manager" "7.10.0"
"@typescript-eslint/types" "7.10.0"
"@typescript-eslint/typescript-estree" "7.10.0"
"@typescript-eslint/types" "8.15.0"
"@typescript-eslint/visitor-keys" "8.15.0"
debug "^4.3.4"
fast-glob "^3.3.2"
is-glob "^4.0.3"
minimatch "^9.0.4"
semver "^7.6.0"
ts-api-utils "^1.3.0"

"@typescript-eslint/[email protected]", "@typescript-eslint/utils@^8.9.0":
version "8.13.0"
Expand All @@ -2656,13 +2646,15 @@
"@typescript-eslint/types" "8.13.0"
"@typescript-eslint/typescript-estree" "8.13.0"

"@typescript-eslint/[email protected].0":
version "7.10.0"
resolved "https://registry.yarnpkg.com/@typescript-eslint/visitor-keys/-/visitor-keys-7.10.0.tgz#2af2e91e73a75dd6b70b4486c48ae9d38a485a78"
integrity sha512-9ntIVgsi6gg6FIq9xjEO4VQJvwOqA3jaBFQJ/6TK5AvEup2+cECI6Fh7QiBxmfMHXU0V0J4RyPeOU1VDNzl9cg==
"@typescript-eslint/[email protected].0":
version "8.15.0"
resolved "https://registry.yarnpkg.com/@typescript-eslint/utils/-/utils-8.15.0.tgz#ac04679ad19252776b38b81954b8e5a65567cef6"
integrity sha512-k82RI9yGhr0QM3Dnq+egEpz9qB6Un+WLYhmoNcvl8ltMEededhh7otBVVIDDsEEttauwdY/hQoSsOv13lxrFzQ==
dependencies:
"@typescript-eslint/types" "7.10.0"
eslint-visitor-keys "^3.4.3"
"@eslint-community/eslint-utils" "^4.4.0"
"@typescript-eslint/scope-manager" "8.15.0"
"@typescript-eslint/types" "8.15.0"
"@typescript-eslint/typescript-estree" "8.15.0"

"@typescript-eslint/[email protected]":
version "8.13.0"
Expand All @@ -2672,6 +2664,14 @@
"@typescript-eslint/types" "8.13.0"
eslint-visitor-keys "^3.4.3"

"@typescript-eslint/[email protected]":
version "8.15.0"
resolved "https://registry.yarnpkg.com/@typescript-eslint/visitor-keys/-/visitor-keys-8.15.0.tgz#9ea5a85eb25401d2aa74ec8a478af4e97899ea12"
integrity sha512-h8vYOulWec9LhpwfAdZf2bjr8xIp0KNKnpgqSz0qqYYKAW/QZKw3ktRndbiAtUz4acH4QLQavwZBYCc0wulA/Q==
dependencies:
"@typescript-eslint/types" "8.15.0"
eslint-visitor-keys "^4.2.0"

"@ungap/structured-clone@^1.2.0":
version "1.2.0"
resolved "https://registry.yarnpkg.com/@ungap/structured-clone/-/structured-clone-1.2.0.tgz#756641adb587851b5ccb3e095daf27ae581c8406"
Expand Down

0 comments on commit c2abf0a

Please sign in to comment.