Merge branch 'main' into feat/in-4422-logger-output-prettify

vuestorefront · Dec 16, 2024 · 84161d8 · 84161d8
2 parents 5f69b05 + 5032bff
commit 84161d8
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 3 deletions.
diff --git a/docs/content/3.middleware/4.reference/change-log.md b/docs/content/3.middleware/4.reference/change-log.md
@@ -1,5 +1,13 @@
 # Change log
 
+## 5.3.2
+
+### Patch Changes
+
+- **[FIXED]** Fix /readyz returning 503 if readinessProbes not passed in middleware.config.ts
+
+Before this fix, sending a GET request to `http://localhost:4000/readyz` would return { "status": "error" } and a HTTP 503 status. This happened only when `readinessProbes` wasn't added to middleware options (the default behavior)
+
 ## 5.3.1
 
 ### Patch Changes

diff --git a/packages/middleware/CHANGELOG.md b/packages/middleware/CHANGELOG.md
@@ -1,5 +1,13 @@
 # Change log
 
+## 5.3.2
+
+### Patch Changes
+
+- **[FIXED]** Fix /readyz returning 503 if readinessProbes not passed in middleware.config.ts
+
+Before this fix, sending a GET request to `http://localhost:4000/readyz` would return { "status": "error" } and a HTTP 503 status. This happened only when `readinessProbes` wasn't added to middleware options (the default behavior)
+
 ## 5.3.1
 
 ### Patch Changes

diff --git a/packages/middleware/package.json b/packages/middleware/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@vue-storefront/middleware",
-  "version": "5.3.1",
+  "version": "5.3.2",
   "main": "lib/index.cjs.js",
   "module": "lib/index.es.js",
   "types": "lib/index.d.ts",

diff --git a/packages/middleware/src/terminus.ts b/packages/middleware/src/terminus.ts
@@ -30,7 +30,7 @@ export const createReadyzHandler =
   };
 
 export const createTerminusOptions = (
-  readinessChecks: ReadinessProbe[]
+  readinessChecks: ReadinessProbe[] = []
 ): TerminusOptions => {
   return {
     useExit0: true,

diff --git a/packages/sdk/package.json b/packages/sdk/package.json
@@ -25,7 +25,7 @@
   "devDependencies": {
     "@types/jest": "^29.0.3",
     "@types/node": "^18.11.17",
-    "@vue-storefront/middleware": "5.3.1",
+    "@vue-storefront/middleware": "5.3.2",
     "axios": "^1.6.7",
     "babel-preset-node": "^5.1.1",
     "isomorphic-fetch": "^3.0.0",