fix(parser#9038): Fix for slot "name" property using interpolation as well… #9143
+44
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as the "slot" property. (vuejs#9038)
|
Did you see there is already #9050 ? |
|
Yes, I missed that originally but submitted the PR because the other one misses a spot a little bit further down (and admittedly because I didn’t see any other easy bugs to get familiar with the Vue source code :D). The added test that checks for interpolation on slot=“” checks for the scenario missed in the other PR. |
satishrdd
reviewed
Jan 18, 2019
| `and can possibly expand into multiple elements. ` + | ||
| `Use the key on a wrapping element instead.` | ||
| ) | ||
| let slotName |
There was a problem hiding this comment.
Why use let here if we are not editing slotName more than once here,why not use const ?
There was a problem hiding this comment.
I was trying to be consistent with the other code but you're right.
Either way there was another PR for this bug so I haven't followed up on this..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… as the "slot" property. (#9038)
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: