Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Pug-to-Handlebars Pipeline #501

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

wyrmisis
Copy link
Collaborator

Intent

This changeset adds Pug to our workflow.

Pug is a less verbose templating engine that outputs to HTML-like syntax. Thankfully, for our purposes, it'll convert to Handlebars just fine.

Why the heck?

  • HTML is super verbose. It's easy to get lost in a tangle of tags.
  • Handlebars templates aren't pre-compiled; they handle the inclusion of partials at runtime. Oftentimes, partials are used for code-sharing and code-splitting. Why foist that cost onto users?

@@ -3,3 +3,4 @@ foundryconfig.json
dist
.DS_Store
.env
mprocs.yaml
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured, while I'm in here, I might as well ignore the config script for the tool I use to run dev and Foundry from one terminal window.

Copy link
Contributor

@Henrik-Bonsmann Henrik-Bonsmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With a new system in place, I think it might be beneficial to make a note of pug and a link to their documentation somewhere in CONTRIBUTING.md so the on-boarding process for new people is as smooth as possible.

Other than that, I like the look and functionality of pug from what I can see.

@wyrmisis
Copy link
Collaborator Author

With a new system in place, I think it might be beneficial to make a note of pug and a link to their documentation somewhere in CONTRIBUTING.md so the on-boarding process for new people is as smooth as possible.

Other than that, I like the look and functionality of pug from what I can see.

Absolutely correct. I'm rolling through existing templates to convert them to use Pug right now, but I'll be sure to update our documentation to mention it.

@anthonyronda
Copy link
Member

I'll look at this after the bugfix release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants