feat: Character Sheet v2 #479

wyrmisis · 2023-11-10T20:40:34Z

Intent

This changeset implements Phase 1 of the new character sheet, while attempting to maintain the existing character sheet.

Wait, phase one? We never discussed phases!

In the interest of getting this sheet out this year, I'm opting to put it up for review at feature parity (plus a little extra) with the current sheet. In my opinion, adding things like spell sources, ability categories, and so on are too disruptive to the existing character sheet; I'd prefer to hold off on them until we can safely end-of-life the old sheet.

What's missing?

Combat tab: The character info fields are a little messy, and they're missing Retainer fields.
Combat tab: The ability to roll HD
Abilities tab: Use the correct icons for the exploration skills
Abilities tab: Language picker. I'd like to use Tagify for this.
Inventory tab: Adding zebra striping to the inventory rows
Magic tab: dragging a prepared spell to another character's spells will cause the recipient to prepare it, too.
The ability to add hotbar macros.

Where did I veer "off road"?

I added a dark theme. Sorry @Godforsaken84 😝
I added a spell slot grid to the top of each spell level on the Magic tab, as well as under the move speed fields on the Combat tab.
Container queries have enabled us to create a flexible UI that adapts to resizing (including on editor fields)
If you drag gear or treasure with a quantity of at least one to another actor, you'll have the option to give that actor a set amount, and optionally deduct that amount from the original owner. We can absolutely remove this if enough modules cover this, though.

Anything else of note?

I'd really appreciate a close look at my drag and drop code. There's just a lot there and I'd like some help simplifying it.
There'll be mentions of FACE, or Form Associated Custom Elements in the code, specifically about how they don't work gracefully in Foundry. for some reason, no matter what, I can't get focus back onto a custom element after editing. Hopefully FACEs work in v12 (because I'm sure the core devs are tired of me asking about it).

Beyond that... This isn't 100% ready to go in, but it can be -- with your help. There's a lot here. I've been staring at it for a long time, and I'm likely missing stuff. Pull the sheet down, and really put it through the ringer.

anthonyronda · 2023-11-11T14:07:15Z

I'll be taking a few screenshots for folks who want to give feedback without pulling it locally

anthonyronda · 2023-11-11T14:33:25Z

Weapons in containers appear bugged: can't be clicked on or dragged out of the container. Drag behavior has some issues we'll address in a separate comment

New actor. I like the little hover animation

anthonyronda · 2023-11-15T15:10:48Z

.eslintrc

@@ -16,7 +16,7 @@
 	"env": {
 		"browser": true
 	},
-	"ignorePatterns": ["**/lang/**/*.json", "**/*.d.ts"],
+	"ignorePatterns": ["rollup.config.mjs", "**/lang/**/*.json", "**/*.d.ts"],


rollup config is removed from linting? any particular reason?

Sorry that I forgot how to contain everything in a single review for a couple of these!

anthonyronda · 2023-11-15T15:13:23Z

shield.svg doesn't appear to be in use

shield2.svg looks like the aspect ratio is a bit messed up?

anthonyronda · 2023-11-15T15:14:30Z

package.json

@@ -51,22 +54,30 @@
    "eslint-plugin-promise": "^6.1.1",
    "eslint-plugin-scanjs-rules": "^0.2.1",
    "eslint-plugin-security": "^1.5.0",
-    "eslint-plugin-simple-import-sort": "^8.0.0",


yeah this one was really being a PITA

anthonyronda · 2023-11-15T15:36:08Z

I could be wrong but I think the Tweaks menu functionality should also be written somewhere as TODO items

anthonyronda · 2023-11-15T15:15:32Z

package.json

+    "@fortawesome/fontawesome-free": "^6.4.0",
+    "@fortawesome/fontawesome-svg-core": "^6.4.0",
+    "@fortawesome/free-solid-svg-icons": "^6.4.0"


I forget what our conversation on this was. Why are these included as dependencies when Foundry includes fontawesome?

anthonyronda · 2023-11-15T15:17:27Z

rollup.config.mjs

 import { defineConfig } from "rollup";
+
+// shared rollup plugins


what is meant by shared vs system rollup plugins? UFT vs OSE?

anthonyronda · 2023-11-15T15:23:04Z

src/components/AbilityScoreField/AbilityScoreField.ts

+    if (!this.hasAttribute("readonly") && !this.hasAttribute("disabled"))
+      this.shadowRoot
+        ?.querySelector("label")
+        ?.addEventListener("click", (e) => {
+          const evt = new Event("roll") as Event & {metaKey: boolean, ctrlKey: boolean};


what is the reasoning here? Why do we check if the ability score is editable before allowing rolls on it? When is it disabled?

anthonyronda · 2023-11-15T15:28:50Z

src/components/CharacterInfoField/CharacterInfoField.css

+  font-size: var(--spacing-full); /* TODO: variables! ems! */
+  line-height: 38px !important;


We only get to use Foundry's font scaling settings if we use Foundry's own font size variables

anthonyronda · 2023-11-15T15:36:53Z

.eslintrc

@@ -16,7 +16,7 @@
 	"env": {
 		"browser": true
 	},
-	"ignorePatterns": ["**/lang/**/*.json", "**/*.d.ts"],
+	"ignorePatterns": ["rollup.config.mjs", "**/lang/**/*.json", "**/*.d.ts"],


Sorry that I forgot how to contain everything in a single review for a couple of these!

anthonyronda

Less of a request for changes, more of a request for dialog :)

anthonyronda · 2023-11-15T15:45:16Z

src/components/CharacterInfoMeter/CharacterInfoMeter.ts

+  get #value() {
+    const value = parseInt(this.getAttribute("value") || '');
+    if (isNaN(value)) return 0;
+    return value;
+  }
+
+  get #max() {
+    const max = parseInt(this.getAttribute("max") || '');
+    if (isNaN(max)) return 100;
+    return max;
+  }
+
+  get #progress() {
+    return (this.#value / this.#max * 100) || 0;
+  }


it's missing the (admittedly hard to make extensible) tick marks for each of the encumbrance step-down points

I like how it looks though

anthonyronda · 2023-11-15T15:49:09Z

src/templates/actors/partials/sheet-v2/character-abilities-tab.hbs

+<uft-expandable-section type="ability" can-create aria-expanded>
+  <h2 slot="heading">{{localize "OSE.category.abilities"}}</h2>


I don't have a lot of imagination for why this has to be expandable. I'll have to go back to the original design to see what that looked like

anthonyronda · 2023-11-15T15:52:59Z

this is frustrating. 5-6 of my review comments got lost :(

feat: v2 Character sheet (brought in from out of sync branch)

f4681fc

wyrmisis mentioned this pull request Nov 10, 2023

WIP: feat: Character sheet for v2 #455

Closed

anthonyronda self-requested a review November 11, 2023 14:05

anthonyronda reviewed Nov 15, 2023

View reviewed changes

anthonyronda requested changes Nov 15, 2023

View reviewed changes

anthonyronda mentioned this pull request Nov 15, 2023

fix: use core font size setting vars #380

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Character Sheet v2 #479

feat: Character Sheet v2 #479

wyrmisis commented Nov 10, 2023

anthonyronda commented Nov 11, 2023

anthonyronda commented Nov 11, 2023

anthonyronda Nov 15, 2023

anthonyronda Nov 15, 2023

anthonyronda commented Nov 15, 2023

anthonyronda Nov 15, 2023

anthonyronda commented Nov 15, 2023

anthonyronda Nov 15, 2023

anthonyronda Nov 15, 2023

anthonyronda Nov 15, 2023

anthonyronda Nov 15, 2023

anthonyronda Nov 15, 2023

anthonyronda left a comment

anthonyronda Nov 15, 2023

anthonyronda Nov 15, 2023

anthonyronda Nov 15, 2023

anthonyronda commented Nov 15, 2023

		import { defineConfig } from "rollup";

		// shared rollup plugins

		font-size: var(--spacing-full); /* TODO: variables! ems! */
		line-height: 38px !important;

		<uft-expandable-section type="ability" can-create aria-expanded>
		<h2 slot="heading">{{localize "OSE.category.abilities"}}</h2>

feat: Character Sheet v2 #479

Are you sure you want to change the base?

feat: Character Sheet v2 #479

Conversation

wyrmisis commented Nov 10, 2023

Intent

Wait, phase one? We never discussed phases!

What's missing?

Where did I veer "off road"?

Anything else of note?

anthonyronda commented Nov 11, 2023

anthonyronda commented Nov 11, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anthonyronda commented Nov 15, 2023

Choose a reason for hiding this comment

anthonyronda commented Nov 15, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anthonyronda left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anthonyronda commented Nov 15, 2023