-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable sign in Button override #2387
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
Do you have a starter example with this override so that we can double-check the behavior?
Yes, you can see on this preview link https://sfj-50d6569--b2bfaststoredev.preview.vtex.app/ The is PR is that https://github.com/vtex-sites/b2bfaststoredev.store/pull/74, we already merged to following with others tasks, but will update the package link after the merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🥳
@ataideverton I already requested the documentation updates here :) |
I didn't manage to use this preview. The sign in button is redirecting to https://b2bdev.vtexfaststore.com/api/io/login, instead of opening the modal. |
@eduardoformiga The modal only opens on authenticated users You can use our production environment Just do the normal login, after the redirect the modal should open (The button will have changed the text from "Sign Up" to "Company") |
Nice! I think it works as expected in the desktop version. On the mobile, I can't simulate. (the button remains as |
The mobile version should be working now, i needed to make a small change. You can test it on this preview. I have also inverted the validation on this one so you don't need to edit the cookie (Since it's a preview) and the modal should open to an unauthenticated user, just to facilitate testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose of this pull request?
During the development of the B2B Self Management feature, we need to customize and add new behaviors to the "My Account" button, making it open a modal instead of going to the
/account
page. While most of this development will happen in an external library, the ability to override this button is important for us.This PR enables just that, the ability to completely override the default SignIn / My Account button.
Starters Deploy Preview
References