feat: noImplicitAny #2379
Merged
feat: noImplicitAny #2379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
pedromtec
force-pushed
the
feat/noImplicitAny
branch
from
cd84852
to
e608d8d
Compare
pedromtec
force-pushed
the
feat/noImplicitAny
branch
from
e608d8d
to
fb4ba8f
Compare
pedromtec
commented
Jul 12, 2024
pedromtec
commented
Jul 12, 2024
pedromtec
commented
Jul 12, 2024
pedromtec
force-pushed
the
feat/noImplicitAny
branch
from
fb4ba8f
to
7f8ec5e
Compare
pedromtec
requested review from
eduardoformiga,
renatamottam,
lariciamota,
hellofanny and
lucasfp13
and removed request for
a team
pedromtec
force-pushed
the
feat/noImplicitAny
branch
from
e28384f
to
2bd013a
Compare
pedromtec
force-pushed
the
feat/noImplicitAny
branch
from
69feedd
to
33bdfc0
Compare
pedromtec
commented
Jul 18, 2024
pedromtec
force-pushed
the
feat/noImplicitAny
branch
from
7d5db63
to
1b7aa31
Compare
lariciamota
reviewed
Aug 2, 2024
| @@ -32,14 +37,14 @@ function SearchDropdown({ sort, ...otherProps }) { | |||
| linkProps={{ | |||
| href: formatSearchPath({ | |||
| term: suggestion, | |||
| sort: sort as SearchState['sort'], | |||
| sort: sort, | |||
There was a problem hiding this comment.
suggestion:
Suggested change
| sort: sort, | |
| sort, |
| }), | ||
| onClick: () => | ||
| onSearchSelection?.( | ||
| suggestion, | ||
| formatSearchPath({ | ||
| term: suggestion, | ||
| sort: sort as SearchState['sort'], | ||
| sort: sort, |
There was a problem hiding this comment.
suggestion:
Suggested change
| sort: sort, | |
| sort, |
lariciamota
reviewed
Aug 2, 2024
hellofanny
reviewed
Aug 2, 2024
packages/cli/src/utils/generate.ts
Outdated
| /** | ||
| * Modify TypeScript compilation settings (tsconfig.json) to disable specific strict | ||
| * type checking rules when files are moved to the .faststore folder. | ||
| * The idea is to change the strict to false when all strict rules are migrated. |
There was a problem hiding this comment.
If I got it right, we will remove this part when all rules are migrated, right?
suggestion: maybe we can add a todo markup here - // TODO:
pedromtec
force-pushed
the
feat/noImplicitAny
branch
from
b02d7b1
to
ff8862a
Compare
|
Team (small change). I changed from ts-expect-error to ts-ignore because ts-expect-error generates an error when the line has no error. In other words, it always expects the line to have an error. However, when I disable noImplictyAny, the lines stop having errors within the .faststore. |
lucasfp13
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
Strict mode in TypeScript is a way to opt into a more strict type-checking behavior to catch more potential issues at compile time. When enabled, it activates a set of stricter type-checking options that enforce more constraints on your code. Here's how it works and what it does:
No Implicit Any (noImplicitAny): This prevents variables and parameters from defaulting to the any type when TypeScript is unable to infer a more specific type. This helps catch cases where you might have forgotten to specify a type or TypeScript can't infer one for you.
To enable strict mode, you can set "strict": true in your
tsconfig.jsonfile. This is equivalent to enabling all of the above options individually.The idea of this initiative is to enable rule by rule incrementally so that it is possible to open smaller PRs with low risk.
Task: https://vtex-dev.atlassian.net/browse/SFS-1124
How it works?
The first PR enables
noImplicitAnyrule. So codes like that will not work:What's the type of address?
How to test it?
The pipeline (build, tests, and lint) should work for @faststore packages and their dependencies (current branch).
Install the version of this PR in the starter.store and test if the build, tests and override feature works.
"@faststore/core": "https://pkg.csb.dev/vtex/faststore/commit/1b7aa312/@faststore/core"
"@faststore/cli": "https://pkg.csb.dev/vtex/faststore/commit/1b7aa312/@faststore/cli",
I welcome other suggestions and help with testing 🥇
Starters Deploy Preview
References