-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow JS files and Folders within the public folder #2221
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 26cecd6:
|
ff46635
to
26cecd6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thank you for your contribution! 🚀
Can you explain further about the motivation of this PR? Currently, we're avoiding enabling JS or any executable files because of security reasons.
Hi @Gmantiqueira!! About allowing JS files: About the creation of folders inside the public folder: |
What's the purpose of this pull request?
This PR adds JS files to the public folder allowed file types.
It also enables the possibility to create folders within the public folder.
How it works?
Add a folder and a file inside it
.faststore
How to test it?
Try to access the file within the preview.
Starters Deploy Preview
https://sfj-f81fa73--marinbrasil.preview.vtex.app/XMLData/tramontina.xml
https://sfj-f81fa73--marinbrasil.preview.vtex.app/sitemap/department-0.xml
https://sfj-f81fa73--marinbrasil.preview.vtex.app/files/service-worker.js