Added check for data types, valid SOAP error message #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbox-admin
commented
Sep 30, 2013
lbox-admin
commented
- Allow undefined/empty parameter only if attribute nillable is set to true
- Check elements for correct data types
- Send valid SOAP message with error
|
I'm closing this PR as there was no activity for more than a year now... |
|
I know this PR was closed a long time ago due to inactivity, but... There's also no conflicts with any of the current code. Is there anything that needs to be done to it to get merged? If it gets merged, it would not only benefit users of this library, but also enable proper TS definition generation. See TimLuq/wsdl-to-ts#8 and TimLuq/wsdl-to-ts#9 If there's anything that needs to be done and @lbox-admin isn't available to do it, I can fork this PR and finish it up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.