Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated source_permissions #360

Closed
wants to merge 1 commit into from
Closed

Remove deprecated source_permissions #360

wants to merge 1 commit into from

Conversation

jkroepke
Copy link
Contributor

@jkroepke jkroepke commented Nov 9, 2019

Follow up: #312

Since I hate deprecation warnings and the old PR looks stale just I create a new.

Pull Request (PR) description

Fix of deprecation warning:
Warning: The source_permissions parameter is deprecated. Explicitly set owner, group, and mode.
(file: .../manifests/ca.pp, line: 127)

This Pull Request (PR) fixes the following issues

Fixes #315

@jkroepke jkroepke force-pushed the fix-deprecated-source-permissions branch 10 times, most recently from 009a595 to df6bfc9 Compare November 9, 2019 13:16
@jkroepke jkroepke force-pushed the fix-deprecated-source-permissions branch from df6bfc9 to 74306f9 Compare November 9, 2019 13:24
@jkroepke jkroepke marked this pull request as ready for review November 9, 2019 18:31
bastelfreak
bastelfreak reviewed Nov 26, 2019
View reviewed changes
manifests/ca.pp
require => File["${etc_directory}/openvpn/${name}"],
}

exec { "copy *.cnf files from easyrsa source to ${name}":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that copying data with an exec resource is a good idea. @alexjfisher any ideas?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm open for new ideas. From #315 I grab the idea with puppetlabs-rsync which use a exec resource to copy data with rsync.

The current solution is a nasty hack. Thats all what I know.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about restore the old behavior

9f54ab8#diff-b386e10e7f4de7981ca1d52c90456a0dL127

@ghoneycutt
Copy link
Member

This would be easier to approve and merge if the PR only dealt with removing the source_permissions attributes. It seems to be changing functionality without tests, which makes it hard to merge.

@jkroepke
Copy link
Contributor Author

jkroepke commented Dec 26, 2019 •
edited
Loading

It seems to be changing functionality without tests, which makes it hard to merge.

Maybe I need some consulting which tests are required here. My goal was to remove source_permissions. Since there is not drop-in replacement for source_permissions. I had to build some workaround to archive the goal what source_permissions does.

I code this PR and test and try out a lot. If the functionally was wrong, the test

puppet-openvpn/spec/acceptance/openvpn_spec.rb

Line 61 in 48acf24

apply_manifest_on(hosts_as('vpnserver'), pp, catch_changes: true)

give a red flag.

Example: https://travis-ci.org/voxpupuli/puppet-openvpn/jobs/609636194

I generally prefer to restore the old exec cp behavior (9f54ab8#diff-b386e10e7f4de7981ca1d52c90456a0dL127) instead this complicated.

@jkroepke jkroepke closed this Jan 19, 2020
@jkroepke jkroepke deleted the fix-deprecated-source-permissions branch April 21, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak left review comments

Assignees
No one assigned
Labels
needs-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

message : The source_permissions parameter is deprecated
3 participants
@jkroepke @ghoneycutt @bastelfreak