New parameter for home directory

[joernott]

This solves #367

[ninaspitfire]

Thanks! Could you please add a section to the README so that people know it's there and how to use it without reading the code?

It will also need a test like this one before we can merge. I can work on the test next week if you don't get to it before then.

Cheers.

[joernott]

Adding to the readme is rather trivial. Writing the test is quite a challenge, as this parameter is not used in the class directly but in the sub classes.

When running tests on our test platform, I encounbtered another issue with floating classes (trying to install the package before the yum repo was available), so I switched from "include" to "contain".

After that, I will try to see, what my test runs write into the logs, so I can write an appropriate test.

[fatmcgav]

@joernott With regards to writing an acceptance test, it should be possible to use the user server-spec resource:

have_home_directory
In order to test a user have a given home directory, you should use have_home_directory matcher.

describe user('root') do
  it { should have_home_directory '/root' }
end

• https://serverspec.org/resource_types.html#user

[ninaspitfire]

Is this patch intended to be used with Logstash installations that are provided by other means (ie. not by this module)? I guess my question is: "how is Logstash getting into a custom location in the first place?".

If I read this correctly, setting the $home_dir won't actually change were the module installs Logstash, since that is defined by the deb/rpm packages.

[joernott]

I am aware of that. Currently, we package our own logstash (and the rest of the stack to achieve compliance to our folder structure rules. We have an ugly wrapper around the puppet-logstash module which creates symlinks and has dependencies on resources inside the puppet-logstash module to work around puppet-logstash using a hard coded file path to determine file locations which are only valid if you use the original .deb|.rpm packages. Even if you unpack the official tar.gz, this module won't work. The puppet-elasticsearch module has a variable $home_dir which they use instead of hard coded paths for that reason. So this PR just introduces that feature.

[vox-pupuli-tasks]

Dear @joernott, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs?
If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com.
You can find my sourcecode at voxpupuli/vox-pupuli-tasks

[vox-pupuli-tasks]

Dear @joernott, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

[joernott]

Rebase done

[ekohl]

The tests didn't run, but I'd expect them to fail. The declaration of $home_dir on line 161 looks invalid to me.

[ekohl]

I still think you need to remove this line:

puppet-logstash/manifests/init.pp

Line 157 in a293c27

$home_dir = '/usr/share/logstash'