-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul repo, Removing bevy_vello_graphics
& bevy_typst
#51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- doc: fix README discord link - chore: remove Nixon copyright from MIT license - chore: add --document-private-items to cargo doc workflow
nixon-voxell
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
Breaking
Introduce breaking changes to the current implementation.
labels
Jun 3, 2024
…lues, update examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Breaking
Introduce breaking changes to the current implementation.
documentation
Improvements or additions to documentation
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
bevy_vello_graphics
into an external repo.bevy_typst
into an external repo.vello
&vello_graphics
feature inmotiongfx_core
.tuple_combinations
proc macro to generate impl definitions for traits for combinations of tuple.GetMutValue
trait for all tuple combinations (up to 20).GetMut
trait on top ofGetMutValue
for easyType
reference on the function level.TL;DR
A new foundational innovation stated below allow us to break away from the previous rigid build struct structure provided by the command extensions:
build_pbr
,build_fsvector
,build_fvector
,build_svector
.It is now encouraged to spawn entities using the "Bevy style":
Which can then be coupled with the
Entity
(id
) to form a flexible actionable "motion" tuple (note that you can put up to 20 items inside thecomps
tuple as long as none of them conflict with each other in terms ofType
).GetMutValue
trait implemented to all kinds of tuple combinationsA new macro called
tuple_combinations!(impl_macro, count)
was added to create implementation of traits for all tuple combinations.This macro is used to implement
GetMutValue
trait so that it implements for all combinations up until 20.Which means this is now valid code:
Rust will now automatically find the correct location of the item in the tuple based on
Type
!Easy
Type
reference usingGetMut
traitSometimes, writing
is quite troublesome. For one because you need to perform type annotation and assign it to a variable before using it. The
GetMut
trait implemented on top ofGetMutValue
trait intends to remove this limitation by allowing you to specify theType
at the function level:Summary
A full example: