rounded rectangle

[juliapaci]

related to #43

auto switching between rounded and non-rounded

how would we do this? seems polymorphic so rust traits would be the only option right?

[juliapaci]

or a simpler solution would be a condition in shape() i.e.

impl VelloVector for VelloRect {
    fn shape(&self) -> impl kurbo::Shape {
       if self.radius == 0 { kurbo::Rect::new(...)}
       else { kurbo::RoundedRect::new(...)}
    }
}

but im not sure which you had in mind

[nixon-voxell]

yeah, I was thinking maybe just a simple if statement? haha not sure if that would worth the performance cost tho?

[juliapaci]

im currently struggling with object safety by return different types. Seems like a new Shape trait with object safety is necessary although it may lack features required for the object's manipulation.

As for performance, i think it would actually be much worse if we use return different types due to dynamic dispatch rather than if we just return a RoundedRect with a radius of 0 some of the time.

[nixon-voxell]

Oh yes, of course, I have not thought of that! haha thanks for pointing it out, then I guess, the easiest solution would be the current implementation or add a new type VelloRoundedRect tho, I think the current implementation is more user friendly.

[juliapaci]

I vote to keep the current implementation until linebender/kurbo#331 gets merged then rewrite with that in mind

[nixon-voxell]

agreed, thanks for pointing out the PR as well :D

[nixon-voxell]

Hey juz a tiny change to fix the rust fmt error, thanks!

[nixon-voxell]

@aymey I also wanted to point out that your changes will be moved into the new repo I created: https://github.com/voxell-tech/bevy_vello_graphics.