Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vortex Dockerfiles #188

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Vortex Dockerfiles #188

merged 2 commits into from
Oct 23, 2024

Conversation

Udit8348
Copy link
Contributor

@Udit8348 Udit8348 commented Oct 9, 2024

There are two main users of Vortex: (1) developers and (2) users. Each user has different needs and requirements for interacting with vortex, as such it makes sense to utilize two Dockerfiles to meet each of their needs:

(1) Developers need to build Vortex so their Dockerfile is structured to make long term development easier
(2) Users just need a clean environment to run prebuilt Vortex and have no need to build the repo from scratch

Detailed documentation regarding each Dockerfile's usage will be added in /docs

@Udit8348
Copy link
Contributor Author

Udit8348 commented Oct 9, 2024

After some consideration, the Dockerfile for users should just pull the latest release of Vortex (from here: https://github.com/vortexgpgpu/vortex/releases). Will be making this change soon

@Udit8348
Copy link
Contributor Author

Udit8348 commented Oct 11, 2024

Need to open some discussion here:
When doing a a clean environment installation of Vortex on Ubuntu:20.04 we have to git clone along with third party submodules. The ./ci/install_dependencies.sh script is missing the cmake dependency. This is interesting, because if this script is already being used in the ci pipeline, how are the thirdparty submodules being built? Are the prebuilt? Is there a different base image?

At the moment, I am not sure but just wanted to leave this comment here before modifying ./ci/install_dependencies.sh

@hyesoon hyesoon merged commit 659ad87 into vortexgpgpu:master Oct 23, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants