indexer: index more details about blocks #1329
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
altergui
force-pushed
the
feat/index-blocks
branch
4 times, most recently
from
29dccc8
to
dbdd78f
Compare
|
@mvdan wdyt in general? and in particular, TestRestoreBackupAndMigrate is failing, since i changed the db columns. what's the best fix? recreate the sqlite-backup-0009.sql.zst ? i understand this would not happen if i avoided modifying 0006_create_table_blocks.sql and instead created a 0012_add_columns_to_table_blocks.sql , which i can also do. |
p4u
reviewed
Jun 11, 2024
altergui
force-pushed
the
feat/index-blocks
branch
from
dbdd78f
to
711f82e
Compare
|
Yes, please add a new migration step. As far as I can tell, and from what we agreed with @p4u, we are treating the database as stable and we should avoid any breaking changes that force us to delete it and re-index everything. In most cases, like adding new columns, it should be easy to do it as a new step anyway. |
mvdan
reviewed
Jun 14, 2024
altergui
force-pushed
the
feat/index-blocks
branch
2 times, most recently
from
f620fc0
to
514c499
Compare
|
TestRestoreBackupAndMigrate is still failing, with the new migration 0013, complaining about a missing column. digging in 🕵️ |
altergui
force-pushed
the
feat/index-blocks
branch
2 times, most recently
from
1d9efe3
to
5184f2d
Compare
Pull Request Test Coverage Report for Build 9545233328Details
💛 - Coveralls |
altergui
force-pushed
the
feat/index-blocks
branch
2 times, most recently
from
af03b7a
to
5da65a6
Compare
this was failing due to my buggy migration 0013. fixed, all tests are passing now |
Pull Request Test Coverage Report for Build 9548791745Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 10041203332Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
altergui
force-pushed
the
feat/index-blocks
branch
4 times, most recently
from
40c4b1c
to
377af13
Compare
since the CreateBlock now fetches the whole block, we need app.NodeClient initialized in all nodes (including seeds), else seeds panic on first Commit
altergui
force-pushed
the
feat/index-blocks
branch
from
377af13
to
6bc1f7e
Compare
altergui
force-pushed
the
feat/index-blocks
branch
from
6bc1f7e
to
f16e92d
Compare
p4u
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needed since we started pruning the blockstore