opt.output: default file name (for apk or aab) is now name of the work dir #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larpon
requested changes
Dec 30, 2023
| default_file_name := opt.app_name.replace(os.path_separator.str(), '').replace(' ', | ||
| mut default_file_name := '' | ||
| if opt.app_name == android.default_app_name { | ||
| default_file_name = os.getwd().all_after_last('/').replace(os.path_separator.str(), '').replace(' ', |
There was a problem hiding this comment.
The name should be resolved from opt.input not os.getwd() as vab can be run from anywhere:
See this example where I've built vab from this PR on my machine:
In this case the output should have been resolved to bezier.apk but it produced instead vab.apk
There was a problem hiding this comment.
Please remove this example, it is already in the V main repository.
Our goal is to have as many as V's examples compatible with vab as possible and since V is one of vab's dependencies already it avoids (a lot of) code duplication that needs to be maintained in two places.
Users can use V's gg examples for testing
There was a problem hiding this comment.
The whole file needs formatting via v fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does and why
When issuing
vab .orvab run .the default file name produced is based on a hard-coded string (V Test App). This PR changes the default file name produced to the work dir (similar to what v compiler does).Why
The default .apk or .aac file name is not matching with the expectation of how a
v .does, hence this PR.