Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to run as Docker Container #3306

Closed
wants to merge 40 commits into from

Conversation

Yoinky3000
Copy link
Contributor

@Yoinky3000 Yoinky3000 commented Jul 1, 2024

Description

As #1239 stalled, I would like to create a new PR to add support to build SD Next as a docker image and run it

User can create SD Next container by running ./docker/container.py
with specifying the compute platform they want to use by flag (--compute [cuda, rocm, cpu])
SD Next itself, venv and cache will be saved in volume (can be disabled)

Notes

Environment and Testing

Docker with Windows 11(Nvidia)
Docker with WSL2 Ubuntu(Nvidia)
Tested with Docker 27.0.3

@Yoinky3000 Yoinky3000 marked this pull request as ready for review July 2, 2024 21:51
@raymanaa
Copy link

raymanaa commented Jul 7, 2024

Testing python3 ./docker/container.py --compute cuda
I'm getting:
image

It might also be interesting to rebase and squash your commits.

@Yoinky3000
Copy link
Contributor Author

Testing python3 ./docker/container.py --compute cuda I'm getting: image

It might also be interesting to rebase and squash your commits.

are you simply copying the files I added in "docker" folder to your SD Next master branch? If thats in case then it is the reason why --uv is not a valid argument, --uv is just recently added to dev branch and isnt pulled to master yet
If you cloned my docker branch, then there should be no way to get "--uv is invalid" error sd the docker branch is based on the dev branch

@Yoinky3000
Copy link
Contributor Author

seems like i messed it up, maybe i should just create the docker branch again with commiting the files in a single commit

@Yoinky3000 Yoinky3000 closed this Jul 7, 2024
@raymanaa
Copy link

raymanaa commented Jul 7, 2024

No! You don't need to!
You can just pull the main, then use:
git rebase -i main
look for a rebase tutorial online, that way you can squash all the commits into a single commit and push again.

Here's a quick overview about git rebase https://www.youtube.com/watch?v=_UZEXUrj-Ds

@Yoinky3000
Copy link
Contributor Author

No! You don't need to! You can just pull the main, then use: git rebase -i main look for a rebase tutorial online, that way you can squash all the commits into a single commit and push again.

Here's a quick overview about git rebase https://www.youtube.com/watch?v=_UZEXUrj-Ds

I already recreated the repo, might just use the new repo now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants