Fix index creation #283
Merged
Fix index creation #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spiess
approved these changes
Mar 21, 2022
|
Given the recent changes on the API, this will become incompatible soon. So it might make sense to wait until the next version of cottontail to merge this. |
|
I suggest merging this now, so it is already fixed for the current version of Cottontail. |
|
This needs merging now as the current behavior on master is broken (Indices are not created) |
silvanheller
added a commit
that referenced
this pull request
Jun 10, 2022
* fixing indices not being created Former-commit-id: f885e70
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes indices not being created (#282), and has also led to two documentation / testing requests to the cottontail API (vitrivr/cottontaildb-proto#9) and cottontail itself (vitrivr/cottontaildb#105)