fix: respect cacheDir when optimizer is enabled
#6910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
hi-ogawa
force-pushed
the
fix-cacheDir
branch
from
6cb2f2b
to
c8fbec3
Compare
hi-ogawa
commented
Nov 15, 2024
Comment on lines
+145
to
+146
| root: testConfig.root ?? viteConfig.test?.root, | ||
| deps: testConfig.deps ?? viteConfig.test?.deps, |
There was a problem hiding this comment.
I added these here to so that root and deps from inline test config can be referenced from VitestOptimizer plugin.
| @@ -677,7 +677,7 @@ export function resolveConfig( | |||
| if (resolved.cache !== false) { | |||
| let cacheDir = VitestCache.resolveCacheDir( | |||
| '', | |||
| resolve(viteConfig.cacheDir, 'vitest'), | |||
| viteConfig.cacheDir, | |||
There was a problem hiding this comment.
vitest suffix is to avoid collision of node_modules/.vite/deps directory, so using it for results.json is not technically necessary.
hi-ogawa
changed the title
cacheDircacheDir when optimizer is enabled
sheremet-va
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cacheDirnot honored ifdeps.optimizer.{mode}.enabledis true #6733cacheDirnot being honored ifdeps.optimizer.{mode}.enabledistrue#6902Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.